Bug 245686
| Summary: | devel/skalibs: Update to 2.9.2.1 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | crest | ||||
| Component: | Individual Port(s) | Assignee: | Tobias C. Berner <tcberner> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | crest, tcberner | ||||
| Priority: | --- | Keywords: | buildisok, needs-qa | ||||
| Version: | Latest | Flags: | crest:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240790 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 238649, 245687, 245694, 245699, 245836 | ||||||
| Attachments: |
|
||||||
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval Attachment -> Details -> maintainer-approval [+] Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/137128305 Moin moin
This seems to break sysutils/runwhen:
Making compile/host/tainnow
cp: ./compile/host/skalibs_sysdeps/tainnow.lib: No such file or directory
Making compile/host/rw-match.o
src/rw-match.c:24:24: error: redefinition of 'div'
enum { unset, eq, eqn, div };
^
/usr/include/stdlib.h:100:8: note: previous definition is here
div_t div(int, int) __pure2;
^
src/rw-match.c:108:30: warning: incompatible pointer to integer conversion assigning to 'unsigned int' from 'div_t (int, int)' [-Wint-conversion]
case '/': units[i].type=div; break;
^~~~
src/rw-match.c:117:24: warning: comparison between pointer and integer ('unsigned int' and 'div_t (*)(int, int)') [-Wpointer-integer-compare]
if (units[i].type!=div || units[i].min>0)
~~~~~~~~~~~~~^ ~~~
src/rw-match.c:153:18: warning: incompatible pointer to integer conversion assigning to 'unsigned int' from 'div_t (int, int)' [-Wint-conversion]
units[i].type=div, units[i].spec=1;
^~~~
src/rw-match.c:162:22: warning: comparison between pointer and integer ('unsigned int' and 'div_t (*)(int, int)') [-Wpointer-integer-compare]
if (units[i].type==div) {
~~~~~~~~~~~~~^ ~~~
There is a namespace collision between runwhen and skalibs. The last runwhen release is from 2015.02.24 and skalibs changed in the last 5 *years*. Trying to build runwhen I ran into these problems: * The name "div" is already used. I solved this by converting all the values in the enum from lower to upper case. * Next skalibs renamed tainnow.lib to sysclock.lib. * While I'm there I replaced env_get() with getenv(3) because env_get() is just a deprecated wrapper around getenv(3). Committed. Thanks. A commit references this bug: Author: tcberner Date: Fri Apr 24 18:41:17 UTC 2020 New revision: 532886 URL: https://svnweb.freebsd.org/changeset/ports/532886 Log: devel/skalibs: update to 2.9.2.1 PR: 245686 Submitted by: crest@rlwinm.de (maintainer) Changes: head/devel/skalibs/Makefile head/devel/skalibs/distinfo head/devel/skalibs/pkg-plist |
Created attachment 213484 [details] Patch bringing the to the latest version. I forgot to publish the updates to the skarnet ports. This PR takes care of the skalibs library used by almot all skarnet software. It closes PR #238649 and #240790 as well.