Bug 246023

(In reply to Daniel Tihanyi from comment #0)
This is the correct bug for renaming the port: bug 246022

Comment 2 Hiroki Tagato 2020-05-04 08:38:15 UTC

Hi Daniel,

Thanks for proposing this port.

Since this is not a totally new port but a new version of existing port sysutils/rundeck, can you prepare a diff file against the latest sysutils/rundeck directory?

The MAINTAINER is specified as "arcade@b1t.name" not you. Is this OK for him/her to maintain this port as well as rundeck2?

Created attachment 214111 [details]
rundeck-rundeck3-diff

Hello Hiroki,

I'm not entirely sure how maintainership works, that's why I left as it is. I am happy maintain rundeck3 (also rundeck2 if needed).

I attached a diff that will remove the current sysutils/rundeck port and add sysutils/rundeck3 (still with old maintainer).

Comment 4 Hiroki Tagato 2020-05-05 06:00:10 UTC

(In reply to Daniel Tihanyi from comment #3)

I may have been a big vague when asking you to make a diff file.

I would like it to be a diff between rundeck2 and rundeck3 in the same sysutils/rundeck directory. Can you update the diff again?

Regarding maintainer, let's ask Volodymyr.

Volodymyr, do you feel comfortable about being the maintainer of the new sysutils/rundeck3, which is proposed by Daniel? If not, I will pass maintainership to Daniel.

Hello.

I guess Daniel already volunteered to maintain the port so why not? Actually I'm happy to give away rundeck2 also - we moved all hosts to Linux so I kindda lost the need in it. It's a legacy version so not much updates there. I only suggested to leave rundeck2 in ports as we (as a company) still have an ongoing effort to upgrade to rundeck3 and it's not going out nicely...

@Daniel. welcome to the club, buddy. I'm not a pro at maintaining/creating ports, but that shouldn't be that hard. I think I even ripped most of the rundeck port from some other java port. Everything will work the same way: you are adding a bug, attaching diff, someone with a commit bit chimes in and commits it. If you need help - just say it out loud. There are mailing lists, groups at matrix, at telegram, irc, almost everywhere.

Cheers!

Comment 6 Hiroki Tagato 2020-05-06 05:57:01 UTC

(In reply to Volodymyr Kostyrko from comment #5)

Thanks Volodymyr for your reply and efforts put into maintaining the port.

Daniel, can you update the diff file with MAINTAINER set to yourself? I will set the maitainer of sysutils/rundeck2 port to you as well.

I look forward to the updated patch.

Created attachment 214199 [details]
rundeck diff to rundeck3

@Hiroki: I attached a new diff, I hope this time it's correct.
@Volodymyr: Thank you, I will do my best. :-)

Comment 8 commit-hook 2020-05-07 11:11:43 UTC

A commit references this bug:

Author: tagattie
Date: Thu May  7 11:10:41 UTC 2020
New revision: 534258
URL: https://svnweb.freebsd.org/changeset/ports/534258

Log:
  There is rundeck version 3 available and version 2 is still supported.
  So it is good to have both versions in the ports. This commit is to:
  - Add rundeck ver. 3 as rundeck3
  - Preserve rundeck ver. 2 as rundeck2 for users who want to stay in version 2
  - Pass maintainership to submitter

  PR:		246022 246023
  Submitted by:	Daniel Tihanyi <daniel.tihanyi@tetragir.com>
  Approved by:	arcade@b1t.name (maintainer), pizzamig (mentor)

Changes:
  head/MOVED
  head/sysutils/Makefile
  head/sysutils/rundeck/
  head/sysutils/rundeck2/
  head/sysutils/rundeck2/Makefile
  head/sysutils/rundeck2/pkg-plist
  head/sysutils/rundeck3/
  head/sysutils/rundeck3/Makefile
  head/sysutils/rundeck3/distinfo
  head/sysutils/rundeck3/files/rundeck.in
  head/sysutils/rundeck3/pkg-plist

Comment 9 Hiroki Tagato 2020-05-07 11:13:29 UTC

Committed, thanks!