Bug 246060
| Summary: | [NEW PORT] games/libretro-play: Play! - PlayStation 2 Emulator | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ivan Rozhuk <rozhuk.im> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Loïc Bartoletti <lbartoletti> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | dmenelkir, lbartoletti, rozhuk.im, tcberner | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ivan Rozhuk
2020-04-30 14:49:50 UTC
Moin moin Instead of passing cmake bools to CMAKE_ARGS with -DBUILD_PLAY:BOOL=OFF I would suggest to use CMAKE_ON and CMAKE_OFF e.g. CMAKE_OFF=BUILD_PLAY mfg Tobias Created attachment 214404 [details]
patch
For information, there is an issue on i386 arch. https://github.com/jpd002/Play-/issues/906 (In reply to Loïc Bartoletti from comment #3) Thanks! I check only on AMD64. Will update path after close https://github.com/jpd002/Play-/issues/906 There is other issues, like: https://github.com/jpd002/Play-/issues/447 Looks like Play! does not work with at least some OpenGL games :( There is list of games: https://github.com/jpd002/Play-Compatibility/issues Created attachment 214761 [details] patch Update to latest master with i386 build fix. Add URL to pkg-descr: Game capability tracker: https://github.com/jpd002/Play-Compatibility/issues Thanks. Can you convert your post-patch part to files patch, please? (In reply to Loïc Bartoletti from comment #7) I prefer to leave "sed" patches - they does not requires re-make patch on every small change in sources. IMHO patch files required in cases where sed can not be used: many lines of code added/deleted/changed. No progress on this? (In reply to rozhuk.im from comment #8) Unfortunately, this does not respect the rule (4.4.3 https://www.freebsd.org/doc/en/books/porters-handbook/book.html#slow-patch) where sed should only be used to replace variables. The great advantage of having patch files is: you will notice, when they stop applying. Created attachment 218989 [details]
patch 0.33
(In reply to Daniel Menelkir from comment #9) I forgot about this, mostly because it disappoint me: I want to play need for speed but it does not work, like many others OpenGL games. (In reply to Loïc Bartoletti from comment #10) This is not rule, it is recommendations. 4.4.3 - chapter number. Current version make simple changes in make files, if something goes wrong - it will fail to build. I agree that using sed in most cases is bad idea for source files. (In reply to rozhuk.im from comment #12) Did you try porting PCSX2 instead? I heard they finally adapting the code to 64bit, but I didn't tried yet. (In reply to Daniel Menelkir from comment #14) No, I was looking for "game plugins" for kodi. But now I think is better to have option to switch from kodi to retroarch and back. Looks like PCSX2 will requires 2 ports: https://github.com/PCSX2/pcsx2 https://github.com/coldscientist/libretro-pcsx2-launcher I will try this, but don't know when. (In reply to rozhuk.im from comment #15) Yes, but PCSX2 have a huge compatibility list compared to play. A commit references this bug: Author: lbartoletti Date: Wed Nov 18 11:33:07 UTC 2020 New revision: 555636 URL: https://svnweb.freebsd.org/changeset/ports/555636 Log: [NEW PORT] games/libretro-play: Play! - PlayStation 2 Emulator Play! is a PlayStation 2 emulator for Windows, macOS, UNIX, Android & iOS platforms. WWW: https://purei.org/ PR: 246060 Submitted by: rozhuk.im@gmail.com Changes: head/games/Makefile head/games/libretro/Makefile head/games/libretro-play/ head/games/libretro-play/Makefile head/games/libretro-play/distinfo head/games/libretro-play/files/ head/games/libretro-play/files/patch-Source_CMakeLists.txt head/games/libretro-play/files/patch-Source_ui__libretro_CMakeLists.txt head/games/libretro-play/files/patch-deps_CodeGen_build__cmake_CMakeLists.txt head/games/libretro-play/files/patch-deps_Dependencies_cmake-modules_Header.cmake head/games/libretro-play/files/patch-deps_Dependencies_ghc__filesystem_CMakeLists.txt head/games/libretro-play/files/patch-deps_Framework_build__cmake_Framework__Common.cmake head/games/libretro-play/pkg-descr Committed, with minor changes. Thanks! (sorry for the delay) |
