Bug 246060 - [NEW PORT] games/libretro-play: Play! - PlayStation 2 Emulator
Summary: [NEW PORT] games/libretro-play: Play! - PlayStation 2 Emulator
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Loïc Bartoletti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-30 14:49 UTC by rozhuk.im
Modified: 2020-09-10 08:41 UTC (History)
3 users (show)

See Also:


Attachments
patch (4.38 KB, patch)
2020-04-30 14:49 UTC, rozhuk.im
no flags Details | Diff
patch (4.33 KB, patch)
2020-05-12 08:05 UTC, rozhuk.im
no flags Details | Diff
patch (4.40 KB, patch)
2020-05-22 16:54 UTC, rozhuk.im
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rozhuk.im 2020-04-30 14:49:50 UTC
Created attachment 213956 [details]
patch

Play! is a PlayStation 2 emulator for Windows, macOS, UNIX,
Android & iOS platforms.


WWW: https://purei.org/
Comment 1 Tobias C. Berner freebsd_committer 2020-04-30 18:30:34 UTC
Moin moin 

Instead of passing cmake bools to CMAKE_ARGS with 
   		-DBUILD_PLAY:BOOL=OFF 

I would suggest to use CMAKE_ON and CMAKE_OFF

e.g. 

CMAKE_OFF=BUILD_PLAY


mfg Tobias
Comment 2 rozhuk.im 2020-05-12 08:05:29 UTC
Created attachment 214404 [details]
patch
Comment 3 Loïc Bartoletti freebsd_committer 2020-05-22 06:28:04 UTC
For information, there is an issue on i386 arch. https://github.com/jpd002/Play-/issues/906
Comment 4 rozhuk.im 2020-05-22 10:02:40 UTC
(In reply to Loïc Bartoletti from comment #3)

Thanks!
I check only on AMD64.
Will update path after close https://github.com/jpd002/Play-/issues/906

There is other issues, like: https://github.com/jpd002/Play-/issues/447
Looks like Play! does not work with at least some OpenGL games :(
Comment 5 rozhuk.im 2020-05-22 10:17:21 UTC
There is list of games: https://github.com/jpd002/Play-Compatibility/issues
Comment 6 rozhuk.im 2020-05-22 16:54:42 UTC
Created attachment 214761 [details]
patch

Update to latest master with i386 build fix.
Add URL to pkg-descr: Game capability tracker: https://github.com/jpd002/Play-Compatibility/issues
Comment 7 Loïc Bartoletti freebsd_committer 2020-05-27 08:45:45 UTC
Thanks.
Can you convert your post-patch part to files patch, please?
Comment 8 rozhuk.im 2020-05-27 22:11:56 UTC
(In reply to Loïc Bartoletti from comment #7)

I prefer to leave "sed" patches - they does not requires re-make patch on every small change in sources.
IMHO patch files required in cases where sed can not be used: many lines of code added/deleted/changed.