Bug 246099
| Summary: | login.conf documents passwordtime as unimplemented in base | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Documentation | Reporter: | Andriy Gapon <avg> | ||||
| Component: | Manual Pages | Assignee: | Mateusz Piotrowski <0mp> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | 0mp, ceri, doc, felix.the.red | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Maybe this is a case where we can fix the code to match the documentation. (In reply to Conrad Meyer from comment #1) Do you really mean removing support for passwordtime from FreeBSD? :-) Created attachment 228273 [details] login.conf.5 patch Move passwordtime from RESERVED CAPABILITIES to AUTHENTICATION. This has been supported since 2010, see bug 93473. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=e7f8f3b95e1ff76765f1d2f4412b95f6ff5abe25 commit e7f8f3b95e1ff76765f1d2f4412b95f6ff5abe25 Author: Felix Johnson <felix.the.red@gmail.com> AuthorDate: 2021-10-06 20:47:02 +0000 Commit: Mateusz Piotrowski <0mp@FreeBSD.org> CommitDate: 2021-10-06 20:51:22 +0000 login.conf.5: Mark passwordtime as implemented login.conf.5 listed passwordtime in RESERVED CAPABILITIES, which is a section for capabilities not implemented in the base system. However, passwordtime has been implemented in the base for several years now. PR: 246099 Reported by: avg Reviewed by: 0mp MFC after: 3 days lib/libutil/login.conf.5 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) Thanks for the patch! A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=a9077f3e0c11a878bd4a8a729e1e9c3147c135e5 commit a9077f3e0c11a878bd4a8a729e1e9c3147c135e5 Author: Felix Johnson <felix.the.red@gmail.com> AuthorDate: 2021-10-06 20:47:02 +0000 Commit: Mateusz Piotrowski <0mp@FreeBSD.org> CommitDate: 2021-10-15 13:14:53 +0000 login.conf.5: Mark passwordtime as implemented login.conf.5 listed passwordtime in RESERVED CAPABILITIES, which is a section for capabilities not implemented in the base system. However, passwordtime has been implemented in the base for several years now. PR: 246099 Reported by: avg Reviewed by: 0mp MFC after: 3 days (cherry picked from commit e7f8f3b95e1ff76765f1d2f4412b95f6ff5abe25) lib/libutil/login.conf.5 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=75bb69738e427fd34fe2695d71b5381c2cc35066 commit 75bb69738e427fd34fe2695d71b5381c2cc35066 Author: Felix Johnson <felix.the.red@gmail.com> AuthorDate: 2021-10-06 20:47:02 +0000 Commit: Mateusz Piotrowski <0mp@FreeBSD.org> CommitDate: 2021-10-15 13:16:00 +0000 login.conf.5: Mark passwordtime as implemented login.conf.5 listed passwordtime in RESERVED CAPABILITIES, which is a section for capabilities not implemented in the base system. However, passwordtime has been implemented in the base for several years now. PR: 246099 Reported by: avg Reviewed by: 0mp MFC after: 3 days (cherry picked from commit e7f8f3b95e1ff76765f1d2f4412b95f6ff5abe25) lib/libutil/login.conf.5 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) |
login.conf puts passwordtime in RESERVED CAPABILITIES section that has this preamble: The following capabilities are reserved for the purposes indicated and may be supported by third-party software. They are not implemented in the base system. But in fact it looks that passwordtime is implemented in the base for several years now.