Bug 248433
| Summary: | net/vinagre: move mandatory dependency on net/avahi-app to option AVAHI | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Vladimir Druzenko <vvd> | ||||||
| Component: | Individual Port(s) | Assignee: | freebsd-gnome (Nobody) <gnome> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | tcberner, vvd | ||||||
| Priority: | --- | Flags: | tcberner:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 216960 [details]
move mandatory dependency on net/avahi-app to option AVAHI
Moin moin, Thanks. Committed with the additional build dependency on lang/vala. mfg Tobias Moin moin, Thanks. Committed with the additional build dependency on lang/vala. mfg Tobias A commit references this bug: Author: tcberner Date: Sun Aug 2 15:25:38 UTC 2020 New revision: 543970 URL: https://svnweb.freebsd.org/changeset/ports/543970 Log: net/vinagre: move dependency on avahi-app into AVAHI option - add missing build time dependency on valac PR: 248433 Submitted by: VVD <vvd@unislabs.com> Changes: head/net/vinagre/Makefile |
Created attachment 216959 [details] move mandatory dependency on net/avahi-app to option AVAHI vinagre doesn't require libavahi-common.so:net/avahi-app if option AVAHI is off. Using this patch for serveral years without any issues. Just tested. - If net/avahi-app and option AVAHI is off - vinagre binary doesn't require it: $ ldd /usr/local/bin/vinagre | grep avahi $ readelf -d /usr/local/bin/vinagre | grep avahi - If option AVAHI is on - vinagre binary linked with: $ readelf -d /usr/local/bin/vinagre | grep avahi 0x0000000000000001 NEEDED Shared library: [libavahi-ui-gtk3.so.0] 0x0000000000000001 NEEDED Shared library: [libavahi-common.so.3] 0x0000000000000001 NEEDED Shared library: [libavahi-client.so.3] 0x0000000000000001 NEEDED Shared library: [libavahi-glib.so.1] 0x0000000000000001 NEEDED Shared library: [libavahi-gobject.so.0] Do I need to add all these libs to the dependency list? libavahi-common.so.3, libavahi-client.so.3, libavahi-glib.so.1 and libavahi-gobject.so.0 provided by net/avahi-app.