Bug 248446
| Summary: | databases/sqlite3: Change candidates of OPTIONS_RADIO_RL | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yasuhiro Kimura <yasu> | ||||||||
| Component: | Individual Port(s) | Assignee: | Jochen Neumeister <joneum> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | joneum, madpilot, pavelivolkov | ||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(pavelivolkov) |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248459 | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 248428, 248459 | ||||||||||
| Attachments: |
|
||||||||||
(In reply to Yasuhiro KIMURA from comment #0) While it is true no supported FreeBSD version has libreadline in base anymore, the readline USES still has support for that, so it makes sense for the port to leverage that, so the port can still work also on older version, without really harming anyone. Anyway my comment is not a strong objection to this change, but I don't think there is a reason to reduce support for older FreeBSD version when there is no real advantage. BTW since your patch removes the double readline option, the CONFIGURE_ENABLE helper can be used: READLINE_CONFIGURE_ENABLE= readline Created attachment 217000 [details] Patch for READLINE option using CONFIGURE_ENABLE helper I'm sending an updated patch using CONFIGURE_ENABLE helper in place of CONFIGURE_ON as I suggested in comment #1 Created attachment 217094 [details]
patch
The diff file changed to last revision. From the "(revision 544163)" to "(revision 544349)".
Changed the PORTREVISION variable.
Removed unneeded LIBEDIT_DESC and "USES= ncurses".
In the target "post-install" added list for check used shared libraries.
(In reply to Pavel Volkov from comment #3) Thx Pavel. Thix fix my error in poudriere. Is your Patch ready to landed? (I will take it) (In reply to Jochen Neumeister from comment #4) Hello. Yes, you may used this patch file. This is a more practical. "USES=readline" automatically check and switch library to a ports or to a system realization. "USES=libedit" work only with a ports realization. libedit from the system, in current imported version, don't work with unicode characters and don't recommended for used (maybe). Don't passes check "Mk/Script/qa.sh", baselibs function. A commit references this bug: Author: joneum Date: Mon Aug 17 11:56:04 UTC 2020 New revision: 545157 URL: https://svnweb.freebsd.org/changeset/ports/545157 Log: databases/sqlite3: Change candidates of OPTIONS_RADIO_RL Removed unneeded LIBEDIT_DESC and "USES= ncurses". In the target "post-install" added list for check used shared libraries. PR: 248446 Submitted by: maintainer Sponsored by: Netzkommune GmbH Changes: head/databases/sqlite3/Makefile |
Created attachment 216984 [details] Patch file Since no supported FreeBSD version has libreadline.so in base system, there is no difference between READLINES and READLINEP. So replace them with single READLINE option.