Bug 248559

Summary: net-im/gajim: update to 1.2.2
Product: Ports & Packages Reporter: yzrh
Component: Individual Port(s)Assignee: Ruslan Makhmatkhanov <rm>
Status: In Progress ---    
Severity: Affects Some People CC: mazhe
Priority: --- Flags: bugzilla: maintainer-feedback? (rm)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch against r532905
none
Patch against r532905 (fix PY_FLAVOR)
none
Patch against r532905
none
testport log (gzipped)
none
Patch against r532905
none
testport log (gzipped)
none
nbxmpp-1.0.2
none
pygobject3-common-3.36.1
none
py-gobject3 (update pkg-plist)
none
testport log of py37-gobject3-3.36.1
none
testport log of py37-nbxmpp-1.0.2
none
testport log of pygobject3-common-3.36.1 none

Description yzrh 2020-08-09 18:25:12 UTC
Release notes: https://gajim.org/post/2020-07-08-gajim-1.2.1-released/

As mentioned in release notes,  bundled plug-ins will be enabled
automatically.  Shell we at least include these two common ones:

https://dev.gajim.org/gajim/gajim-plugins/-/wikis/OmemoGajimPlugin
https://dev.gajim.org/gajim/gajim-plugins/-/wikis/UrlImagePreviewPlugin

Or just package all of them?
Comment 1 yzrh 2020-08-09 18:27:22 UTC
Created attachment 217117 [details]
Patch against r532905

It builds.  Poudriere does not complain.
Please test it more.
Comment 2 Ruslan Makhmatkhanov freebsd_committer 2020-08-10 08:40:20 UTC
Hello, this is a major port Makefile rewrite. Would you clarify more why it is needed? For example, why you dropped PY_FLAVOR part, why gajim needs libsoup in LIB_DEPENDS etc?
Comment 3 yzrh 2020-08-10 18:56:21 UTC
Created attachment 217135 [details]
Patch against r532905 (fix PY_FLAVOR)

Sorry for delay.  I totally forgot about PY_FLAVOR,
it is fixed.

libsoup is listed in runtime requirement:

https://dev.gajim.org/gajim/gajim/-/commit/48cf636600d41a880fc9285d3a2b225936d998bd
Comment 4 yzrh 2020-08-20 15:08:03 UTC
Created attachment 217381 [details]
Patch against r532905
Comment 5 yzrh 2020-08-20 15:08:46 UTC
Created attachment 217382 [details]
testport log (gzipped)

portlint -C
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
0 fatal errors and 1 warning found.
Comment 6 yzrh 2020-08-20 15:25:56 UTC
Created attachment 217383 [details]
Patch against r532905

Remove unused USES=xorg
Comment 7 yzrh 2020-08-20 15:26:30 UTC
Created attachment 217384 [details]
testport log (gzipped)

portlint -C
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
0 fatal errors and 1 warning found.
Comment 8 Matthieu Volat 2020-08-25 16:43:26 UTC
This patch works as far as packaging is concerned, but running gajim requires first a py-nbxmpp update to at least 1.0.2:

% gajim
Traceback (most recent call last):
[...]
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 786, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'nbxmpp>=1.0.2' distribution was not found and is required by gajim


I checked the 1.2.0 branch, it also required some newer gnome/glib stuff that was is currently in ports, has something changed?
Comment 9 yzrh 2020-08-26 12:26:05 UTC
https://dev.gajim.org/gajim/python-nbxmpp/-/tags

It was tagged recently.  I guess we need to at least
update net-im/py-nbxmpp.
Comment 10 yzrh 2020-08-26 19:33:39 UTC
Okay.  I think glib is a tough one.  I tried to compile
2.64.5,  it fails with:

Checking for function "ngettext": NO
Library intl found: NO
Comment 11 yzrh 2020-08-26 21:19:08 UTC
Created attachment 217555 [details]
nbxmpp-1.0.2
Comment 12 yzrh 2020-08-26 21:20:50 UTC
Created attachment 217556 [details]
pygobject3-common-3.36.1
Comment 13 yzrh 2020-08-26 21:21:42 UTC
Created attachment 217557 [details]
py-gobject3 (update pkg-plist)
Comment 14 yzrh 2020-08-26 21:22:41 UTC
Created attachment 217558 [details]
testport log of py37-gobject3-3.36.1
Comment 15 yzrh 2020-08-26 21:23:18 UTC
Created attachment 217559 [details]
testport log of py37-nbxmpp-1.0.2
Comment 16 yzrh 2020-08-26 21:23:38 UTC
Created attachment 217560 [details]
testport log of pygobject3-common-3.36.1
Comment 17 yzrh 2020-08-26 21:29:43 UTC
devel/glib20 >=2.60.0 is next.  Let me find out
what needs to be done tomorrow.