Bug 249002
| Summary: | devel/check: Switch to CMake, use release archive and enable "make test" | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||||||
| Status: | Closed Works As Intended | ||||||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) |
||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 217635 [details]
Patch for check v2
Fix install path for manpage
Friendly ping Patch is outdated. And what's the benefit of using cmake? Created attachment 218118 [details]
Patch for check v3
Rebased, made a few cosmetic changes
Compiles faster (slightly)
====> Compressing man pages (compress-man)
6.12s real 12.22s user 2.54s sys
====> Compressing man pages (compress-man) (without test)
5.13s real 5.15s user 1.55s sys
====> Compressing man pages (compress-man) (with test)
6.16s real 9.40s user 1.77s sys
Much cleaner Makefile and creates properly versioned linked library file
Best regards,
Daniel
cmake is much heavier than gmake. I'd rather use gmake for now. Quite a few users already uses CMake so I figured it wasn't much of a deal and being faster was positive improvement apart from versioning the shared library and avoiding additional Makefile patching. |
Created attachment 217633 [details] Patch for check * Switch to CMake * Use release archive instead of pulling source from GitHub repo as suggested by 5.4.3 in Porter's Handbook * Add "make test" target * Drop DOCS and EXAMPLES menu options Tested on FreeBSD 13.0-CURRENT #0 r358620 (AMD64) (make test) Poudriere OK 12.1-RELEASE (AMD64)