Bug 249002 - devel/check: Switch to CMake, use release archive and enable "make test"
Summary: devel/check: Switch to CMake, use release archive and enable "make test"
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-29 22:50 UTC by daniel.engberg.lists
Modified: 2020-10-02 11:36 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
Patch for check (3.47 KB, patch)
2020-08-29 22:50 UTC, daniel.engberg.lists
no flags Details | Diff
Patch for check v2 (3.48 KB, patch)
2020-08-29 23:39 UTC, daniel.engberg.lists
no flags Details | Diff
Patch for check v3 (3.02 KB, patch)
2020-09-20 20:24 UTC, daniel.engberg.lists
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description daniel.engberg.lists 2020-08-29 22:50:19 UTC
Created attachment 217633 [details]
Patch for check

* Switch to CMake
* Use release archive instead of pulling source from GitHub repo as suggested by 5.4.3 in Porter's Handbook
* Add "make test" target
* Drop DOCS and EXAMPLES menu options

Tested on FreeBSD 13.0-CURRENT #0 r358620 (AMD64) (make test)
Poudriere OK 12.1-RELEASE (AMD64)
Comment 1 daniel.engberg.lists 2020-08-29 23:39:50 UTC
Created attachment 217635 [details]
Patch for check v2

Fix install path for manpage
Comment 2 daniel.engberg.lists 2020-09-13 20:32:55 UTC
Friendly ping
Comment 3 Sunpoet Po-Chuan Hsieh freebsd_committer 2020-09-20 19:34:02 UTC
Patch is outdated. And what's the benefit of using cmake?
Comment 4 daniel.engberg.lists 2020-09-20 20:24:44 UTC
Created attachment 218118 [details]
Patch for check v3

Rebased, made a few cosmetic changes
Comment 5 daniel.engberg.lists 2020-09-20 20:28:56 UTC
Compiles faster (slightly)

====> Compressing man pages (compress-man)
        6.12s real              12.22s user             2.54s sys

====> Compressing man pages (compress-man) (without test)
        5.13s real              5.15s user              1.55s sys

====> Compressing man pages (compress-man) (with test)
        6.16s real              9.40s user              1.77s sys

Much cleaner Makefile and creates properly versioned linked library file

Best regards,
Daniel
Comment 6 Sunpoet Po-Chuan Hsieh freebsd_committer 2020-10-02 10:18:49 UTC
cmake is much heavier than gmake. I'd rather use gmake for now.
Comment 7 daniel.engberg.lists 2020-10-02 11:36:03 UTC
Quite a few users already uses CMake so I figured it wasn't much of a deal and being faster was positive improvement apart from versioning the shared library and avoiding additional Makefile patching.