Bug 249481
| Summary: | security/libnitrokey: update to 3.6 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Thibault Payet <monwarez> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | diizzy, pi | ||||||||||
| Priority: | --- | Keywords: | buildisok | ||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/192148606 Is upstream release tarball useable? If so please use it. (5.4.3 in Porter's Handbook) Can you perhaps add a "make test" target using offline-tests? Looks good otherwise! Best regards, Daniel Created attachment 218120 [details]
diff of the port
Use release tarball from github release
I didn't find how to make the MASTER_SITE more readable
Created attachment 218122 [details]
diff of the port
forget to remove commented line
To add the test target, I would need to change a cmake configuration. Does having a non default TEST option for that is the standard ? MASTER_SITES looks fine! If you don't mind and if it makes it more clean sure why not switch to cmake? Usually something like this is enough https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=249002 however you can define your own do-test: section https://svnweb.freebsd.org/ports/head/net-p2p/libtorrent-rasterbar/Makefile?revision=547585&view=markup#l79 Created attachment 218131 [details]
update with test target
Adding the offline test seems to work fine, I test it directly inside the ports tree, not in a poudriere jail so I didn't check for filesystem violation
===> Testing for libnitrokey-3.6
[0/1] cd /usr/ports/security/libnitrokey/work/.build && /usr/local/bin/ctest --force-new-ctest-process
Test project /usr/ports/security/libnitrokey/work/.build
Start 1: runs
1/2 Test #1: runs ............................. Passed 0.02 sec
Start 2: minimal
2/2 Test #2: minimal .......................... Passed 0.01 sec
100% tests passed, 0 tests failed out of 2
Total Test time (real) = 0.03 sec
Looks great! Poudriere testport OK 12.1-RELEASE (amd64) Committed, thanks! A commit references this bug: Author: pi Date: Fri Sep 25 14:52:57 UTC 2020 New revision: 550043 URL: https://svnweb.freebsd.org/changeset/ports/550043 Log: security/libnitrokey: update 3.6-RC1 -> 3.6 - LibremKey and FreeBSD support. Extended API - also add test target PR: 249481 Submitted by: Thibault Payet <monwarez@mailoo.org> (maintainer) Reviewed by: daniel.engberg.lists@pyret.net Changes: head/security/libnitrokey/Makefile head/security/libnitrokey/distinfo head/security/libnitrokey/pkg-plist |
Created attachment 218107 [details] diff of the port Update libnitrokey to 3.6 Bump portrevision of security/nitrokey-app if needed It pass QA