Bug 250399
| Summary: | emulators/openmsx: Update to 16.0 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Menelkir <dmenelkir> | ||||||
| Component: | Individual Port(s) | Assignee: | Rainer Hurling <rhurlin> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | rhurlin | ||||||
| Priority: | --- | Flags: | dmenelkir:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| URL: | https://openmsx.org/ | ||||||||
| Attachments: |
|
||||||||
Created attachment 218808 [details]
Patch without PORTREVISION and pkg-plist
Hi Daniel,
Thanks for the patch. I tried it and found some minor issues:
- Remove PORTREVISION. New version begins w/o
- Remove pkg-plist, because PLIST does its job
The attached patch creates a much smaller port with same results. What do you think about it?
(In reply to Rainer Hurling from comment #1) Oops, I was updating other port before and the make makeplist was automatic. Good enough to me, thanks. Hi Daniel, I just opened a review on Phabricator[1]. [1] https://reviews.freebsd.org/D26825 In the review process, arrowd asked about the reason for all these renames in the patches. Can you explain it, please? (In reply to Rainer Hurling from comment #4) Because the method used (bswap) was causing an error in the build, so it was suggested to just exchange that (no big deal to freebsd side). The other patch was a compiler check, as I'm still using gcc. it doesn't represent a problem on freebsd side. I am still studying the software to compile without gcc, but there are still some pending problems. I'm in contact with he developers, soon this patches will not be necessary. A commit references this bug: Author: rhurlin Date: Sat Oct 17 10:55:03 UTC 2020 New revision: 552553 URL: https://svnweb.freebsd.org/changeset/ports/552553 Log: emulators/openmsx: Update to 16.0 Changelog[1]: - Lots of new features and fixes - New version scheme (0.15.0 to 16.0) [1] https://raw.githubusercontent.com/openMSX/openMSX/RELEASE_16_0/doc/release-notes.txt Ports changes: - Update PORTVERSION - Remove BROKEN - Update distinfo - Add patches with FreeBSD gcc specific changes - Use secure URL in pkg-descr PR: 250399 Submitted by: Daniel Menelkir <menelkir@itroll.org> (maintainer) Approved by: arrowd (mentor), tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D26825 Changes: head/emulators/openmsx/Makefile head/emulators/openmsx/distinfo head/emulators/openmsx/files/ head/emulators/openmsx/files/patch-src_utils_endian.hh head/emulators/openmsx/files/patch-src_utils_sha1.cc head/emulators/openmsx/files/patch-src_utils_tiger.cc head/emulators/openmsx/pkg-descr Committed, thanks :) And thanks for the explanations about the patches! |
Created attachment 218802 [details] openmsx-v1.diff Update to 16.0. - Lots of new features and fixes - New version scheme - Fixed the issues in FreeBSD