Bug 250399 - emulators/openmsx: Update to 16.0
Summary: emulators/openmsx: Update to 16.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Rainer Hurling
URL: https://openmsx.org/
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-16 15:39 UTC by Daniel Menelkir
Modified: 2020-10-17 10:56 UTC (History)
1 user (show)

See Also:
dmenelkir: maintainer-feedback+

Attachments
openmsx-v1.diff (37.05 KB, patch)
2020-10-16 15:39 UTC, Daniel Menelkir 		no flags Details | Diff
Patch without PORTREVISION and pkg-plist (6.95 KB, patch)
2020-10-16 19:27 UTC, Rainer Hurling 		rhurlin: maintainer-approval?
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Menelkir 2020-10-16 15:39:28 UTC 
Created attachment 218802 [details]
openmsx-v1.diff

Update to 16.0.
- Lots of new features and fixes
- New version scheme
- Fixed the issues in FreeBSD
Comment 1 Rainer Hurling freebsd_committer freebsd_triage 2020-10-16 19:27:36 UTC 
Created attachment 218808 [details]
Patch without PORTREVISION and pkg-plist

Hi Daniel,

Thanks for the patch. I tried it and found some minor issues:

- Remove PORTREVISION. New version begins w/o
- Remove pkg-plist, because PLIST does its job

The attached patch creates a much smaller port with same results. What do you think about it?
Comment 2 Daniel Menelkir 2020-10-16 20:33:54 UTC 
(In reply to Rainer Hurling from comment #1)
Oops, I was updating other port before and the make makeplist was automatic.
Good enough to me, thanks.
Comment 3 Rainer Hurling freebsd_committer freebsd_triage 2020-10-17 06:41:59 UTC 
Hi Daniel,

I just opened a review on Phabricator[1].


[1] https://reviews.freebsd.org/D26825
Comment 4 Rainer Hurling freebsd_committer freebsd_triage 2020-10-17 07:42:09 UTC 
In the review process, arrowd asked about the reason for all these renames in the patches.

Can you explain it, please?
Comment 5 Daniel Menelkir 2020-10-17 08:54:49 UTC 
(In reply to Rainer Hurling from comment #4)
Because the method used (bswap) was causing an error in the build, so it was suggested to just exchange that (no big deal to freebsd side). 
The other patch was a compiler check, as I'm still using gcc. it doesn't represent a problem on freebsd side. I am still studying the software to compile without gcc, but there are still some pending problems. 
I'm in contact with he developers, soon this patches will not be necessary.
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-10-17 10:55:19 UTC 
A commit references this bug:

Author: rhurlin
Date: Sat Oct 17 10:55:03 UTC 2020
New revision: 552553
URL: https://svnweb.freebsd.org/changeset/ports/552553

Log:
  emulators/openmsx: Update to 16.0

  Changelog[1]:
  - Lots of new features and fixes
  - New version scheme (0.15.0 to 16.0)

  [1] https://raw.githubusercontent.com/openMSX/openMSX/RELEASE_16_0/doc/release-notes.txt

  Ports changes:
  - Update PORTVERSION
  - Remove BROKEN
  - Update distinfo
  - Add patches with FreeBSD gcc specific changes
  - Use secure URL in pkg-descr

  PR:		250399
  Submitted by:	Daniel Menelkir <menelkir@itroll.org> (maintainer)
  Approved by:	arrowd (mentor), tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D26825

Changes:
  head/emulators/openmsx/Makefile
  head/emulators/openmsx/distinfo
  head/emulators/openmsx/files/
  head/emulators/openmsx/files/patch-src_utils_endian.hh
  head/emulators/openmsx/files/patch-src_utils_sha1.cc
  head/emulators/openmsx/files/patch-src_utils_tiger.cc
  head/emulators/openmsx/pkg-descr
Comment 7 Rainer Hurling freebsd_committer freebsd_triage 2020-10-17 10:56:51 UTC 
Committed, thanks :)

And thanks for the explanations about the patches!