Bug 250414
| Summary: | ftp/curl: may automatically pick up libzstd, make that an explicit option | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Matthias Andree <mandree> | ||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | dewayne, sunpoet | ||||
| Priority: | --- | Flags: | mandree:
maintainer-feedback-
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
(In reply to Matthias Andree from comment #0) Thanks Matthias, sorely needed. I've noticed this behaviour (of picking up zstd) in openssl 1.1.1h on FreeBSD12.2S too. I had to resequence my port building order to avoid this auto-annoying ;) tendency. A commit references this bug: Author: mandree Date: Sun Nov 1 20:10:07 UTC 2020 New revision: 553854 URL: https://svnweb.freebsd.org/changeset/ports/553854 Log: ftp/curl: avoid auto-enabling ZSTD, make explicit option; ensure GSSAPI compilation. Since August 2020, curl would auto-enable ZSTD if available while configuring, this would however not propagate to the LIB_DEPENDS. Make sure to explicitly control ZSTD by introducing an option that defaults to off. While here, also mark BROKEN if GSSAPI_BASE is selected while krb5 is installed when building. PR: 250414 Approved by: sunpoet@ (maintainer timeout, 14d) Changes: head/ftp/curl/Makefile maintainer timeout, 14 days, committing |
Created attachment 218835 [details] patch to make ZSTD an explicit option to control ./configure behaviour and avoid inconsistency between auto-detection and LIB_DEPENDS curl 7.73 (or generally Curl versions since 2020 August) may, through configure, auto-detect libzstd and then use it. I am proposing a patch to control this behaviour explicitly through an option (enabled by default) so as to register the dependency properly and avoid this issue in "env DEVELOPER=yes make -C /usr/ports/ftp/curl stage-qa": ====> Running Q/A tests (stage-qa) Error: /usr/local/lib/libcurl.so.4.7.0 is linked to /usr/local/lib/libzstd.so.1 from archivers/zstd but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libzstd.so:archivers/zstd NOTE you may want to bump PORTREVISION to clean this up in existing installs.