Bug 252736
| Summary: | [NEW PORT] editor/linux-wps-office: Complete office suite with PDF editor | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Martin Filla <freebsd> | ||||||||||||||||||
| Component: | Individual Port(s) | Assignee: | Guangyuan Yang <ygy> | ||||||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||||||
| Severity: | Affects Only Me | CC: | danfe, freebsd, lwhsu, mpysw, pfg, trasz, ygy | ||||||||||||||||||
| Priority: | --- | Keywords: | patch | ||||||||||||||||||
| Version: | Latest | Flags: | freebsd:
maintainer-feedback+
|
||||||||||||||||||
| Hardware: | amd64 | ||||||||||||||||||||
| OS: | Any | ||||||||||||||||||||
| URL: | https://www.wps.com/ | ||||||||||||||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256682 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
Created attachment 221627 [details]
wps-office.shar
Created attachment 221633 [details]
wps-office.shar
Port directory should be changed to `editor/linux-wps-office' and PKGNAMEPREFIX=linux- added to the Makefile. Take a look at other Linux binary ports we have in the tree for reference. (In reply to Alexey Dokuchaev from comment #3) Correction: editors (plural), of course, but then again, I'm sure that it is the best category for big and complex integrated office suites that contain far more than a simple text editor. (In reply to Martin Filla from comment #0) After a quick fix of the plist (missing one line) and some trimming, I got wps running - thanks! I found that the entry point is not correct though: ➜ ~ wps wps does not exist! ➜ ~ which wps /usr/local/bin/wps I need to run /compat/linux/opt/kingsoft/wps-office/office6/wps directly to get it open. Could you fix this? Created attachment 225678 [details]
committer proposed patch
(In reply to Martin Filla from comment #0) Hi Martin, I uploaded my proposed patch that is based on what you had and with several issues fixed, including: - fixing plist - fixing entry script prefixes and desktop files (post-patch) - fixing et executable permissions - other style and infra tweaks Please review it, so that I can commit it with your approval. Thanks! Created attachment 225696 [details]
committer proposed patch v2
Minor nit update, no functional changes
There is currently an issue that whenever selected Settings -> Settings on the GUI, the whole application segfault. I do believe getting this into the tree first is beneficial though. Very cool .. thanks! As a suggestion you may want to add some minimal fonts as run time dependencies. These three are metrically compatible to Microsoft fonts (I included them in Apache OpenOffice): x11-fonts/croscorefonts-fonts-ttf x11-fonts/crosextrafonts-caladea-ttf x11-fonts/crosextrafonts-carlito-ttf (In reply to Pedro F. Giffuni from comment #10) Bah .. defining which fonts are compatible with others may be an issue. For now just let the port as-is. :) (In reply to Guangyuan Yang from comment #9) Added trasz@ as he may want to look at the Settings segfault. I did quickly checked the Settings segfault yesterday, then I reproduced it in Linux (Fedora) /facepalm. Please see the demo uploaded. So, while all other functionalities work perfectly, I think we can just commit it if the patch looks good for everyone :) Created attachment 225721 [details]
app segfault under Linux
Created attachment 225722 [details]
committer proposed patch v3
More cosmetic improvements.
(In reply to Guangyuan Yang from comment #15) > More cosmetic improvements. In pkg-descr, I read: "... WPS Word, WPS PDF, WPS Excel & WPS Presentation" -- usage of contractions such as ``&'' is discouraged in port descriptions and should be spelled out as "and" (also, don't forget Oxford comma). Created attachment 225725 [details]
committer proposed patch v4
- pkg-descr improvements suggested by danfe@
- Cosmetic fixes for Makefile
- Fix plist issues
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3381abb5a8b00f63ef0e98a2a92ec379ded59f69 commit 3381abb5a8b00f63ef0e98a2a92ec379ded59f69 Author: Guangyuan Yang <ygy@FreeBSD.org> AuthorDate: 2021-06-11 10:09:20 +0000 Commit: Guangyuan Yang <ygy@FreeBSD.org> CommitDate: 2021-06-11 10:09:20 +0000 editors/linux-wps-office: New port: WPS Office for Linux WPS Office is a complete office suite with PDF editor. PR: 252736 Submitted by: Martin Filla <freebsd@sysctl.cz> (in part) Approved by: lwhsu (mentor) editors/Makefile | 1 + editors/linux-wps-office/Makefile (new) | 60 + editors/linux-wps-office/distinfo (new) | 3 + editors/linux-wps-office/pkg-descr (new) | 8 + editors/linux-wps-office/pkg-plist (new) | 4275 ++++++++++++++++++++++++++++++ 5 files changed, 4347 insertions(+) Thanks everyone! |
Created attachment 221626 [details] wps-office.shar Hi, this is linux new port wps-office.