Bug 253251

Summary: Hardware Revision Realtek 8117
Product: Base System Reporter: Christian Gutzler <christiangutzler>
Component: kernAssignee: freebsd-net (Nobody) <net>
Status: Open ---    
Severity: Affects Many People CC: christiangutzler, markj
Priority: ---    
Version: 12.2-STABLE   
Hardware: amd64   
OS: Any   
Attachments:
Description Flags
Patch none

Description Christian Gutzler 2021-02-04 16:04:40 UTC
My builtin Realtek 8117 is not attached (return 6) due to unknown HW revision / Chip rev. 0x54800000, Mac rev. 0x00200000.

As far as I understood, this seems to happen from time to time with new Realtek chips and the new HW ID maybe just needs to be included in the list.

I just added a photo of the screen, since I was sitting in front of it. Let me know if you need the output as text or anything else.

Greetings from Mannheim
Christian
Comment 1 Christian Gutzler 2021-02-11 20:42:28 UTC
Created attachment 222373 [details]
Patch

My first patch ever, hope I did everything right.
Please review.

THX
Comment 2 Christian Gutzler 2021-02-11 20:44:01 UTC
Comment on attachment 222373 [details]
Patch

My first patch ever. Hope I did everything right. Pls review. THX. Christian
Comment 3 Mark Johnston freebsd_committer 2021-02-12 17:35:58 UTC
Hi, a couple of notes:
- the description string "8168H/8111H" is duplicated, it should probably be "8117"
- I think the RL_HWREV_8117 driver flags are probably close to RL_HWREV_8168EP.  The 8169 NICs are quite old.

Presumably the driver is basically functional with your patch applied?
Comment 4 Christian Gutzler 2021-02-16 21:21:25 UTC
Hi,correct. It´s basically functional. Copied tha values from 0x54000000 assuming 0x54800000 would be a revision of this.

I´ll test with the changes proposed by you.
Comment 5 Christian Gutzler 2021-05-03 09:59:04 UTC
(Finally) Tested your proposals and it seems to work but the MAC looks odd :

re0: flags=8802<BROADCAST,SIMPLEX,MULTICAST> metric 0 mtu 1500 options=8209b<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,WOL_MAGIC,LINKSTATE>
        ether 00:00:00:00:00:00
        media: Ethernet autoselect (1000baseT <full-duplex>)
        status: active
        nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>
Comment 6 Christian Gutzler 2021-05-03 10:01:51 UTC
(In reply to Christian Gutzler from comment #5)

P.S. Did this on FreeBSD 13.0 RELEASE