Bug 253507
| Summary: | audio/moc: Improve user experience by depending on FFmpeg as default option | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
| Status: | Closed Not Accepted | ||||||
| Severity: | Affects Only Me | Keywords: | buildisok | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(rob) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/263179086 Thanks! I don't want to make ffmpeg a dependency by default. Also I think there is already an option to use ffmpeg so the better performance is there for those that want it. Any reason for this? It would be very nice if we could move away from abdandomware such as libmad, being abdandomware it's also hard(er) to keep track of security issues such as r517408 Regards, Daniel I want to close this issue, but I don't know how. It would be nice however if you could elaborate a bit more for further reference. I don't think the abandonware argument makes sense since moc itself has generally been unmaintained for an equally long while. It is a shame, since I do still use it daily. |
Created attachment 222436 [details] Patch for moc Instead of pulling in lib(flac) and libmad utilize ffmpeg which also supports a lot more formats and offers better performance overall. Can't find a browsable online repo so I'll refer to the source code instead. decoder_plugins/ffmpeg/ffmpeg.c L325 and below Also utilize USES= localbase:ldflags instead setting it manually via CPP and LDFLAGS Compile and runtime-tested on FreeBSD 13.0-BETA2 (amd64) (make, make check-plist)