Bug 253507

Summary: audio/moc: Improve user experience by depending on FFmpeg as default option
Product: Ports & Packages Reporter: daniel.engberg.lists
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: New ---    
Severity: Affects Only Me CC: rzinkov
Priority: --- Keywords: buildisok
Version: LatestFlags: bugzilla: maintainer-feedback? (rzinkov)
Hardware: Any   
OS: Any   
Description Flags
Patch for moc none

Description daniel.engberg.lists 2021-02-14 14:10:53 UTC
Created attachment 222436 [details]
Patch for moc

Instead of pulling in lib(flac) and libmad utilize ffmpeg which also supports a lot more formats and offers better performance overall.

Can't find a browsable online repo so I'll refer to the source code instead.
decoder_plugins/ffmpeg/ffmpeg.c L325 and below

Also utilize USES= localbase:ldflags instead setting it manually via CPP and LDFLAGS

Compile and runtime-tested on FreeBSD 13.0-BETA2 (amd64) (make, make check-plist)
Comment 1 Automation User 2021-03-01 00:51:09 UTC
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/263179086
Comment 2 rzinkov 2021-03-01 01:42:40 UTC

I don't want to make ffmpeg a dependency by default. Also I think there is already an option to use ffmpeg so the better performance is there for those that want it.
Comment 3 daniel.engberg.lists 2021-03-03 07:37:23 UTC
Any reason for this? It would be very nice if we could move away from abdandomware such as libmad, being abdandomware it's also hard(er) to keep track of security issues such as r517408