Bug 254435

Summary: security/passivedns: Add JSON option (log output support)
Product: Ports & Packages Reporter: Shawn Michael <freebsd>
Component: Individual Port(s)Assignee: Jason Helfman <jgh>
Status: In Progress ---    
Severity: Affects Some People CC: freebsd, jgh, shadowbq
Priority: --- Keywords: feature, needs-patch, needs-qa
Version: LatestFlags: bugzilla: maintainer-feedback? (shadowbq)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to add JSON output support
none
Revised patch based on recommendations none

Description Shawn Michael 2021-03-20 16:02:19 UTC
Created attachment 223452 [details]
Patch to add JSON output support

This is a patch to enable the -j and -J flags in passivedns.  These flags allow for the output of JSON formatted logs.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-05-13 01:03:26 UTC
Thanks for the report and patch. 

Review items:

 - Rename option name to JSON (via what dependency its provided is less important than the feature itself)
 - Rename option description to "Enable JSON log format support"
 - Add the option to OPTIONS_DEFAULT
Comment 2 Shawn Michael 2021-05-13 23:44:20 UTC
Created attachment 224918 [details]
Revised patch based on recommendations

I've uploaded a new patch with the requested revisions

Option is renamed to: JSON
Description is changed to: Enable JSON log format support
Added: OPTIONS_DEFAULT = JSON
Comment 3 Jason Helfman freebsd_committer 2021-05-25 16:30:30 UTC
Adding maintainer for feedback. Added PORTREVISION bump to this.

-jgh
Comment 4 Shawn Michael 2021-08-20 16:14:36 UTC
(In reply to Jason Helfman from comment #3)
Since the maintainer seems to be MIA, is it possible to proceed without their comment/review?

Shawn