Bug 254435
| Summary: | security/passivedns: Add JSON option (log output support) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Shawn Michael <freebsd> | ||||||
| Component: | Individual Port(s) | Assignee: | Jason Helfman <jgh> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | freebsd, jgh, shadowbq | ||||||
| Priority: | --- | Keywords: | feature, needs-patch, needs-qa | ||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(shadowbq) |
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Thanks for the report and patch. Review items: - Rename option name to JSON (via what dependency its provided is less important than the feature itself) - Rename option description to "Enable JSON log format support" - Add the option to OPTIONS_DEFAULT Created attachment 224918 [details]
Revised patch based on recommendations
I've uploaded a new patch with the requested revisions
Option is renamed to: JSON
Description is changed to: Enable JSON log format support
Added: OPTIONS_DEFAULT = JSON
Adding maintainer for feedback. Added PORTREVISION bump to this. -jgh (In reply to Jason Helfman from comment #3) Since the maintainer seems to be MIA, is it possible to proceed without their comment/review? Shawn A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f51671acbd7d33d22cd4d3a8176d34bad237edde commit f51671acbd7d33d22cd4d3a8176d34bad237edde Author: Jason Helfman <jgh@FreeBSD.org> AuthorDate: 2021-10-06 19:12:15 +0000 Commit: Jason Helfman <jgh@FreeBSD.org> CommitDate: 2021-10-06 19:13:53 +0000 security/passivedns: add JSON option PR: 254435 (based on) Submitted by: freebsd@monkeyspunk.net Approved by: maintainer timeout security/passivedns/Makefile | 7 +++++++ 1 file changed, 7 insertions(+) Thanks for the report! This has been committed. -jgh |
Created attachment 223452 [details] Patch to add JSON output support This is a patch to enable the -j and -J flags in passivedns. These flags allow for the output of JSON formatted logs.