Bug 254435 - security/passivedns: Add JSON option (log output support)
Summary: security/passivedns: Add JSON option (log output support)
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jason Helfman
URL:
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-03-20 16:02 UTC by Shawn Michael
Modified: 2021-05-25 16:30 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (shadowbq)


Attachments
Patch to add JSON output support (402 bytes, patch)
2021-03-20 16:02 UTC, Shawn Michael
no flags Details | Diff
Revised patch based on recommendations (548 bytes, patch)
2021-05-13 23:44 UTC, Shawn Michael
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Michael 2021-03-20 16:02:19 UTC
Created attachment 223452 [details]
Patch to add JSON output support

This is a patch to enable the -j and -J flags in passivedns.  These flags allow for the output of JSON formatted logs.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-05-13 01:03:26 UTC
Thanks for the report and patch. 

Review items:

 - Rename option name to JSON (via what dependency its provided is less important than the feature itself)
 - Rename option description to "Enable JSON log format support"
 - Add the option to OPTIONS_DEFAULT
Comment 2 Shawn Michael 2021-05-13 23:44:20 UTC
Created attachment 224918 [details]
Revised patch based on recommendations

I've uploaded a new patch with the requested revisions

Option is renamed to: JSON
Description is changed to: Enable JSON log format support
Added: OPTIONS_DEFAULT = JSON
Comment 3 Jason Helfman freebsd_committer 2021-05-25 16:30:30 UTC
Adding maintainer for feedback. Added PORTREVISION bump to this.

-jgh