Bug 256061
| Summary: | [New port] editors/linux-sublime-merge: sophisticated GUI Git client by the creators of Sublime Text | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Matías Pizarro <matias> | ||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||
| Status: | Closed Overcome By Events | ||||||||||
| Severity: | Affects Only Me | CC: | ericbsd, ygy | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| URL: | https://www.sublimemerge.com/ | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 247219 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 225180 [details]
Initial port shar v2
Triage: unfortunately, I am way too overcommitted to take a look at this myself. So, removing myself from Cc:. Created attachment 225377 [details]
Initial port shar v3
editors/linux-sublime-merge: Sublime Merge provides a zippy GUI toolkit, a powerful syntax highlighting engine and a custom high-performance Git reading library. This is the initial shar file. The port ships with integrations for KDE, XFCE, Thunar, Konqueror, Nautilus, Nemo and: * installs icons * installs desktop entry * requires Linuxulator passes QA - portlint: OK (looks fine.) - testport: OK (poudriere: 130amd64) - portclippy: OK (all green) - portfmt -D: OK (no warning) editors/linux-sublime-merge: Sublime Merge provides a zippy GUI toolkit, a powerful syntax highlighting engine and a custom high-performance Git reading library. This is the initial shar file. The port: * installs icons * installs desktop entry * requires Linuxulator * installs license Sublime Merge may be downloaded and evaluated for free, however a license must be purchased for continued use. passes QA - portlint: OK (looks fine.) - testport: OK (poudriere: 130amd64) - portclippy: OK (all green) - portfmt -D: OK (no warning) (this comment obsoletes all previous comments) (In reply to Matías Pizarro from comment #0) Hi Matías, thanks for the patch, I have some quick review items: - Why do we need PKGNAMESUFFIX=merge instead of just sublime-merge? From a quick glance, it seems to be a different software than Sublime Text. - pkg-descr seems to be describing Sublime Text instead of sublime-merge as well. - I would use .for loops in the do-install step to clean it up. Ping ;) I was looking to had this port Matías Pizarro are you still working on this? An updated version of this patch has been committed without proper credit given, closing the PR. https://cgit.freebsd.org/ports/commit/?id=1e90dc8251955ca3bbf2bbe8af0924d53d9206d8 |
Created attachment 225161 [details] Initial port shar Hi Mark, Here is a port for Sublime Merge 2