Bug 256061 - [New port] editors/linux-sublime-merge: sophisticated GUI Git client by the creators of Sublime Text
Summary: [New port] editors/linux-sublime-merge: sophisticated GUI Git client by the c...
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://www.sublimemerge.com/
Keywords:
Depends on:
Blocks: 247219
  Show dependency tree / graph
 
Reported: 2021-05-21 22:30 UTC by Matías Pizarro
Modified: 2021-10-13 03:09 UTC (History)
2 users (show)

See Also:

Attachments
Initial port shar (9.17 KB, text/plain)
2021-05-21 22:30 UTC, Matías Pizarro 		no flags Details
Initial port shar v2 (9.32 KB, text/plain)
2021-05-22 16:36 UTC, Matías Pizarro 		no flags Details
Initial port shar v3 (9.32 KB, text/plain)
2021-05-30 14:31 UTC, Matías Pizarro 		matias: maintainer-approval+
Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matías Pizarro 2021-05-21 22:30:40 UTC 
Created attachment 225161 [details]
Initial port shar

Hi Mark,

Here is a port for Sublime Merge 2
Comment 1 Matías Pizarro 2021-05-22 16:36:04 UTC 
Created attachment 225180 [details]
Initial port shar v2
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2021-05-23 04:42:56 UTC 
Triage: unfortunately, I am way too overcommitted to take a look at this myself.  So, removing myself from Cc:.
Comment 3 Matías Pizarro 2021-05-30 14:31:22 UTC 
Created attachment 225377 [details]
Initial port shar v3
Comment 4 Matías Pizarro 2021-05-30 14:38:18 UTC 
editors/linux-sublime-merge: Sublime Merge provides a zippy GUI toolkit, a powerful syntax highlighting engine and a custom high-performance Git reading library.

This is the initial shar file.

The port ships with integrations for KDE, XFCE, Thunar, Konqueror, Nautilus, Nemo and:
 * installs icons
 * installs desktop entry
 * requires Linuxulator

passes QA
  - portlint: OK (looks fine.)
  - testport: OK (poudriere: 130amd64)
  - portclippy: OK (all green)
  - portfmt -D: OK (no warning)
Comment 5 Matías Pizarro 2021-05-30 14:53:09 UTC 
editors/linux-sublime-merge: Sublime Merge provides a zippy GUI toolkit, a powerful syntax highlighting engine and a custom high-performance Git reading library.

This is the initial shar file.

The port:
 * installs icons
 * installs desktop entry
 * requires Linuxulator
 * installs license

Sublime Merge may be downloaded and evaluated for free, however a license must be purchased for continued use.

passes QA
  - portlint: OK (looks fine.)
  - testport: OK (poudriere: 130amd64)
  - portclippy: OK (all green)
  - portfmt -D: OK (no warning)

(this comment obsoletes all previous comments)
Comment 6 Guangyuan Yang freebsd_committer freebsd_triage 2021-06-09 23:08:00 UTC 
(In reply to Matías Pizarro from comment #0)

Hi Matías, thanks for the patch, I have some quick review items:

- Why do we need PKGNAMESUFFIX=merge instead of just sublime-merge? From a quick glance, it seems to be a different software than Sublime Text.
- pkg-descr seems to be describing Sublime Text instead of sublime-merge as well.
- I would use .for loops in the do-install step to clean it up.
Comment 7 Guangyuan Yang freebsd_committer freebsd_triage 2021-06-29 20:39:30 UTC 
Ping ;)
Comment 8 Eric Turgeon freebsd_committer freebsd_triage 2021-10-01 21:27:24 UTC 
I was looking to had this port Matías Pizarro are you still working on this?
Comment 9 Guangyuan Yang freebsd_committer freebsd_triage 2021-10-13 03:09:44 UTC 
An updated version of this patch has been committed without proper credit given, closing the PR.

https://cgit.freebsd.org/ports/commit/?id=1e90dc8251955ca3bbf2bbe8af0924d53d9206d8