Bug 257238

Summary: mail/postfixadmin: Update to 3.3.9
Product: Ports & Packages Reporter: Daniel Gerzo <danger>
Component: Individual Port(s)Assignee: Kubilay Kocak <koobs>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: ports.maintainer
Priority: --- Flags: ports.maintainer: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/postfixadmin/postfixadmin/blob/postfixadmin-3.3.9/CHANGELOG.TXT
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257845
Attachments:
Description Flags
postfixadmin_3.3.9.patch.txt koobs: maintainer-approval+

Description Daniel Gerzo freebsd_committer freebsd_triage 2021-07-17 22:56:43 UTC 
there is a new version, currently 3.3.9
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-18 02:21:26 UTC 
^Triage: Substantial number of releases/bugfixes, consider MFH. Among other changelog entries...

  - PostfixAdmin requires PHP 7.0 or greater.
  - MySQL 8 compatibility
  - update bundled smarty library (lib/smarty to 3.1.32; includes security fixes)
  - add token to login.php to prevent CSRF
  - Security improvements (setup.php)
  - Users moving to v3.3.0 will find their existing setup_password will no longer work, and will need regenerating (may require UPDATING notes or pkg-message)
Comment 3 ports.maintainer 2021-07-18 18:25:09 UTC 
There have been multiple impediments to getting this done, but it is in progress.
Comment 4 ports.maintainer 2021-08-09 03:06:02 UTC 
see ports/257689
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2021-08-09 03:47:38 UTC 
Created attachment 227031 [details]
postfixadmin_3.3.9.patch.txt

Add patch from bug 257689 submitted by maintainer
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2021-08-09 03:48:37 UTC 
Request feedback from maintainer (per bug 257689 comment 1)
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2021-08-09 03:48:47 UTC 
*** Bug 257689 has been marked as a duplicate of this bug. ***
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2021-08-09 03:49:50 UTC 
@Maintainer Note also: In most cases its appropriate to update existing issues where they reflect/resolve that issue as reported over creating separate issues.
Comment 9 ports.maintainer 2021-08-09 05:55:04 UTC 
(In reply to Kubilay Kocak from comment #8)

I created a new PR because FreeBSD's bugzilla has a long-standing problem where a maintainer can't adequately modify a PR if they don't own it.  Additionally, others had already put updating notes and information in this PR and I didn't want to deal with a committer grabbing the wrong information as I have seen happen numerous times before.

Please close this bug as superceded by 257689.
Comment 10 Kubilay Kocak freebsd_committer freebsd_triage 2021-08-09 07:12:27 UTC 
(In reply to Rin Morningstar from comment #9)

Note: Authors of attachments can modify the maintainer approval flag on those patches, and acknowledge (set) flags that have their email address in the value.

The preference is for continuing issues that have already been opened than create new ones, that are effectively duplicates, and necessitating using depends on. The latter is still preferable than a supercedes, which is not  adequately annotated, as it is unstructured in nature.

Will close this when the dependent issue is resolved.
Comment 11 ports.maintainer 2021-08-23 00:46:13 UTC 
Comment on attachment 227031 [details]
postfixadmin_3.3.9.patch.txt

Rejecting this patch just in case someone misses the updates to ports/257689 and ports/257845.  I can't close this bug as I don't own it, but it can be closed overcome by events.