Bug 257313
| Summary: | [NEW PORT] databases/py-databases: Async database support for Python | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Goran Mekić <meka> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Hiroki Tagato <tagattie> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | lwhsu, meka, python, tagattie | ||||||||||||
| Priority: | --- | Keywords: | feature, needs-qa | ||||||||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback+
|
||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Bug Depends on: | 257332 | ||||||||||||||
| Bug Blocks: | 257315, 257370 | ||||||||||||||
| Attachments: |
|
||||||||||||||
When defined, LICENSE_FILE will cause LICENSE.md to be copied to /usr/local. I though we should always put that variable in Makefile of the port. Of course, once removed, everything is just fine. What should I do for this port and for any other in case license is standard (in this case BSD3CLAUSE) and when it's non-standard one? Of course, I will adjust this port based on the feedback. Thank you! Created attachment 226594 [details]
databases.diff
The setup.py was "funky" and it's the cause why LICENSE.md was installed to /usr/local which is fixed by a patch file now.
Python ports should match their upstream python_requires / *_requires as closely as possible (modulo limitations of our <version-spec>):
setup.py:
...
python_requires='>=3.6',
...
install_requires=['sqlalchemy<1.4', 'aiocontextvars;python_version<"3.7"'],
@Goran You may also want to consider grouping those options up into a DATABASE group, with group description "Database Support" Created attachment 226607 [details]
databases.diff
Python doesn't need to block / be assignee on new ports There appears a more recent version (0.5.3) released. Would you care to update the patch to the latest version? Created attachment 230417 [details]
databases.diff
Patch updated to 0.5.3
Thanks for updating the patch. Here are some comments: - Both MASTER_SITE=CHEESESHOP and USE_GITHUB=yes are specified. Which one is really needed? - Does the source archive include a license file? If so, please specify LICENSE_FILE. - MYSQL_DESC, PGSQL_DESC, and SQLITE_DESC seem unnecessary since they are already defined in bsd.options.desc.mk. Could you update the patch to accomdate those comments? Thanks! Created attachment 230531 [details]
databases.diff
I commented out tests as they are failing in a dependent library. The error is that pymysql.util does not exist any more, yet some library is importing it.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d025e5c68e7e9a9634fc8f2dc3d7ba129c148d20 commit d025e5c68e7e9a9634fc8f2dc3d7ba129c148d20 Author: Goran Mekić <meka@tilda.center> AuthorDate: 2021-12-30 02:19:13 +0000 Commit: Hiroki Tagato <tagattie@FreeBSD.org> CommitDate: 2021-12-30 02:58:27 +0000 databases/py-databases: add port: Async database support for Python Databases gives you simple asyncio support for a range of databases. It allows you to make queries using the powerful SQLAlchemy Core expression language, and provides support for PostgreSQL, MySQL, and SQLite. Databases is suitable for integrating against any async Web framework, such as Starlette, Sanic, Responder, Quart, aiohttp, Tornado, or FastAPI. WWW: https://github.com/encode/databases PR: 257313 Reported by: Goran Mekić <meka@tilda.center> (new maintainer) Reviewed by: koobs databases/Makefile | 1 + databases/py-databases/Makefile (new) | 51 +++++++++++++++++++++++ databases/py-databases/distinfo (new) | 3 ++ databases/py-databases/files/patch-setup.py (new) | 11 +++++ databases/py-databases/pkg-descr (new) | 9 ++++ 5 files changed, 75 insertions(+) Committed, thanks! |
Created attachment 226593 [details] databases.diff QA: * portlint: OK (looks fine.) * testport: OK (poudriere: 13.0, amd64 tested) * maketest: OK (57 passed, 4 skipped, 1 warnings)