Bug 257313 - [NEW PORT] databases/py-databases: Async database support for Python
Summary: [NEW PORT] databases/py-databases: Async database support for Python
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: feature, needs-qa
Depends on: 257332
Blocks: 257370 257315
  Show dependency treegraph
 
Reported: 2021-07-21 14:52 UTC by Goran Mekić
Modified: 2021-07-28 02:20 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback+


Attachments
databases.diff (3.18 KB, patch)
2021-07-21 14:52 UTC, Goran Mekić
no flags Details | Diff
databases.diff (3.76 KB, patch)
2021-07-21 15:39 UTC, Goran Mekić
no flags Details | Diff
databases.diff (4.00 KB, patch)
2021-07-22 12:05 UTC, Goran Mekić
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Goran Mekić 2021-07-21 14:52:47 UTC
Created attachment 226593 [details]
databases.diff

QA:

  * portlint: OK (looks fine.)
  * testport: OK (poudriere: 13.0, amd64 tested)
  * maketest: OK (57 passed, 4 skipped, 1 warnings)
Comment 1 Goran Mekić 2021-07-21 15:02:18 UTC
When defined, LICENSE_FILE will cause LICENSE.md to be copied to /usr/local. I though we should always put that variable in Makefile of the port. Of course, once removed, everything is just fine. What should I do for this port and for any other in case license is standard (in this case BSD3CLAUSE) and when it's non-standard one? Of course, I will adjust this port based on the feedback. Thank you!
Comment 2 Goran Mekić 2021-07-21 15:39:01 UTC
Created attachment 226594 [details]
databases.diff

The setup.py was "funky" and it's the cause why LICENSE.md was installed to /usr/local which is fixed by a patch file now.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-22 01:39:21 UTC
Python ports should match their upstream python_requires / *_requires as closely as possible (modulo limitations of our <version-spec>):

setup.py:
    ...
    python_requires='>=3.6',
    ...
    install_requires=['sqlalchemy<1.4', 'aiocontextvars;python_version<"3.7"'],
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-22 01:40:10 UTC
@Goran You may also want to consider grouping those options up into a DATABASE group, with group description "Database Support"
Comment 5 Goran Mekić 2021-07-22 12:05:21 UTC
Created attachment 226607 [details]
databases.diff
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-28 02:20:11 UTC
Python doesn't need to block / be assignee on new ports