Bug 257577
| Summary: | sysutils/e2tools: Use upstream distfile | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||
| Component: | Individual Port(s) | Assignee: | Li-Wen Hsu <lwhsu> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | fuz, lwhsu | ||||
| Priority: | --- | Flags: | fuz:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Comment on attachment 226896 [details]
Patch for e2tools
I usually use the github-generated distfile because the relationship to the source code is clear. Projects tend to some times make mistakes in the generation of their own distfiles requiring different workarounds with different versions of the port. Just using the auto-generated distfile side steps these issues and makes the build more predictable.
But anyway, we can of course use the upstream distfile.
Tested your patch on armv7 FreeBSD 13.0 with Poudriere and can confirm that it works. Portlint and portclippy like the port still.
I'm for some reason not allowed to set the “maintainer approval” flag on the patch, but I do approve of patch 226896. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=88d174890cc093013c29edc1cb45e0de58d1495c commit 88d174890cc093013c29edc1cb45e0de58d1495c Author: Daniel Engberg <daniel.engberg.lists@pyret.net> AuthorDate: 2021-08-03 19:50:48 +0000 Commit: Li-Wen Hsu <lwhsu@FreeBSD.org> CommitDate: 2021-08-03 19:50:48 +0000 sysutils/e2tools: Use upstream distfile PR: 257577 Approved by: Robert Clausecker <fuz@fuz.su> (maintainer) sysutils/e2tools/Makefile | 6 +++--- sysutils/e2tools/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) |
Created attachment 226896 [details] Patch for e2tools Use upstream official distfile as per guidelines in Porter's Handbook, also removes the need to use autoreconf. Compile tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist)