Bug 257577 - sysutils/e2tools: Use upstream distfile
Summary: sysutils/e2tools: Use upstream distfile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
Depends on:
Reported: 2021-08-03 00:03 UTC by Daniel Engberg
Modified: 2021-08-03 19:51 UTC (History)
2 users (show)

See Also:
fuz: maintainer-feedback+

Patch for e2tools (1.17 KB, patch)
2021-08-03 00:03 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer 2021-08-03 00:03:15 UTC
Created attachment 226896 [details]
Patch for e2tools

Use upstream official distfile as per guidelines in Porter's Handbook, also removes the need to use autoreconf.

Compile tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist)
Comment 1 Robert Clausecker 2021-08-03 08:25:12 UTC
Comment on attachment 226896 [details]
Patch for e2tools

I usually use the github-generated distfile because the relationship to the source code is clear.  Projects tend to some times make mistakes in the generation of their own distfiles requiring different workarounds with different versions of the port.  Just using the auto-generated distfile side steps these issues and makes the build more predictable.

But anyway, we can of course use the upstream distfile.

Tested your patch on armv7 FreeBSD 13.0 with Poudriere and can confirm that it works.  Portlint and portclippy like the port still.
Comment 2 Robert Clausecker 2021-08-03 08:39:14 UTC
I'm for some reason not allowed to set the “maintainer approval” flag on the patch, but I do approve of patch 226896.
Comment 3 commit-hook freebsd_committer 2021-08-03 19:51:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=88d174890cc093013c29edc1cb45e0de58d1495c

commit 88d174890cc093013c29edc1cb45e0de58d1495c
Author:     Daniel Engberg <daniel.engberg.lists@pyret.net>
AuthorDate: 2021-08-03 19:50:48 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2021-08-03 19:50:48 +0000

    sysutils/e2tools: Use upstream distfile

    PR:             257577
    Approved by:    Robert Clausecker <fuz@fuz.su> (maintainer)

 sysutils/e2tools/Makefile | 6 +++---
 sysutils/e2tools/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)