Bug 258716
| Summary: | x11-wm/fvwm3: update to 1.0.4 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Felix Palmen <zirias> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Vanilla I. Shu <vanilla> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | vanilla | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 228171 [details]
0001-x11-wm-fvwm3-update-to-1.0.4
After discussion with a few ppl, I think it's better to enable the new GO option by default. It only pulls in a build dependency (so, building the port yourself, you can disable it if you don't like). The FvwmPrompt binary is kind of large cause it links all the Go dependencies statically, but 2.5MB still isn't much nowadays. Given the usability improvement, it would be nice to have it in the official package.
Created attachment 228172 [details]
0001-x11-wm-fvwm3-update-to-1.0.4
And because I'm too stupid to use git correctly, here's the patch again.
(In reply to Felix Palmen from comment #2) Hi: according the changelog, I think we should remove libbson from LIB_DEPENDS, it replaced by cJSON as internal package. Created attachment 228174 [details] 0001-x11-wm-fvwm3-update-to-1.0.4 (In reply to Vanilla I. Shu from comment #3) Oops, I really missed that one, thanks a lot. Did a few quick build tests confirming this lib dep is indeed unnecessary now! Committed, thanks. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5895b52f8e05e69ac82b6c1c828fc207a17f5a62 commit 5895b52f8e05e69ac82b6c1c828fc207a17f5a62 Author: Vanilla I. Shu <vanilla@FreeBSD.org> AuthorDate: 2021-09-26 00:18:37 +0000 Commit: Vanilla I. Shu <vanilla@FreeBSD.org> CommitDate: 2021-09-26 00:23:20 +0000 x11-wm/fvwm3: update to 1.0.4. ChangeLog: https://github.com/fvwmorg/fvwm3/blob/1.0.4/CHANGELOG.md PR: 258716 Reported by: maintainer x11-wm/fvwm3/Makefile | 34 +++++++++++----------- x11-wm/fvwm3/distinfo | 6 ++-- x11-wm/fvwm3/pkg-plist | 77 ++++++++++++++++++++++++-------------------------- 3 files changed, 56 insertions(+), 61 deletions(-) |
Created attachment 228166 [details] 0001-x11-wm-fvwm3-update-to-1.0.4 New upstream release 1.0.4 Building FvwmPrompt written in Go now works, therefore added option GO to enable it. Disabling XFT and XSM seems broken, therefore removed these options for now. Many options combinations tested with poudriere testport. Attached patch applies with 'git am'.