Bug 259655

Summary: periodic: security/security.functions does not respect ${security_show_success}
Product: Base System Reporter: Rob LA LAU <freebsd>
Component: confAssignee: freebsd-bugs (Nobody) <bugs>
Status: Open ---    
Severity: Affects Some People Keywords: easy, needs-qa
Priority: --- Flags: koobs: mfc-stable13?
koobs: mfc-stable12?
koobs: mfc-stable11-
Version: 13.0-RELEASE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
/etc/periodic/security/security.functions : output message unconditionally none

Description Rob LA LAU 2021-11-05 09:07:34 UTC
Created attachment 229288 [details]
/etc/periodic/security/security.functions : output message unconditionally

Hi,

The check_diff() function in /etc/periodic/security/security.functions only outputs the message if any differences were found.
However, the function should output the message unconditionally, and leave the decision whether or not to display the output to /usr/sbin/periodic; the latter checks the ${security_show_success} variable to make this decision.

Patch attached.

Cheers,
  Rob