Bug 260044

Summary: devel/range-v3: Installs includes incompatible with clang13 (C++20)
Product: Ports & Packages Reporter: Guido Falsi <madpilot>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: henry.hu.sh, mikael
Priority: --- Flags: bugzilla: maintainer-feedback? (henry.hu.sh)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 260042    
Bug Blocks: 260040    
Attachments:
Description Flags
patch none

Description Guido Falsi freebsd_committer freebsd_triage 2021-11-25 08:55:18 UTC 
Created attachment 229722 [details]
patch

Hi,

I recently updated my system to latest HEAD and found out telegram-desktop failed to build with the error at the end of the message.

Please note that to get to that error you should first apply the patch in bug #260042

I found out an upstream patch that fixes the issue, I'm attaching patch to the ports tree including it.

obtained from: https://github.com/ericniebler/range-v3/commit/0487cca29e352e8f16bbd91fda38e76e39a0ed28

------------------------
FAILED: Telegram/lib_base/CMakeFiles/lib_base_crash_report_writer.dir/cmake_pch.hxx.pch 
/usr/bin/c++ -DDESKTOP_APP_DISABLE_CRASH_REPORTS -DDESKTOP_APP_DISABLE_WAYLAND_INTEGRATION -DDESKTOP_APP_USE_PACKAGED -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_IMPLICIT_QCHAR_CONSTRUCTION -DQT_NETWORK_LIB -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_SVG_LIB -DQT_WIDGETS_LIB -D_FORTIFY_SOURCE=2 -I/wrkdirs/usr/ports/net-im/telegram-desktop/work/tdesktop-3.2.5-full/Telegram/lib_base -I/wrkdirs/usr/ports/net-im/telegram-desktop/work/tdesktop-3.2.5-full/Telegram/lib_rpl -I/wrkdirs/usr/ports/net-im/telegram-desktop/work/tdesktop-3.2.5-full/Telegram/lib_crl -isystem /usr/local/include -isystem /usr/local/include/qt5/QtCore/5.15.2 -isystem /usr/local/include/qt5/QtCore/5.15.2/QtCore -isystem /usr/local/include/qt5/QtGui/5.15.2 -isystem /usr/local/include/qt5/QtGui/5.15.2/QtGui -isystem /usr/local/include/qt5 -isystem /usr/local/include/qt5/QtCore -isystem /usr/local/lib/qt5/mkspecs/freebsd-clang -isystem /usr/local/include/qt5/QtGui -isystem /usr/local/include/qt5/QtWidgets -isystem /usr/local/include/qt5/QtNetwork -isystem /usr/local/include/qt5/QtSvg -isystem /usr/local/include/qt5/QtDBus -isystem /usr/local/include/giomm-2.4 -isystem /usr/local/lib/giomm-2.4/include -isystem /usr/local/include/glib-2.0 -isystem /usr/local/lib/glib-2.0/include -isystem /usr/local/include/glibmm-2.4 -isystem /usr/local/lib/glibmm-2.4/include -isystem /usr/local/include/sigc++-2.0 -isystem /usr/local/lib/sigc++-2.0/include -isystem /usr/local/include/gio-unix-2.0 -O2 -pipe -march=nehalem -fstack-protector-strong -fno-strict-aliasing  -DNDEBUG -O2 -pipe -march=nehalem -fstack-protector-strong -fno-strict-aliasing  -DNDEBUG -fstack-protector-all -fstack-clash-protection -fPIC -fno-strict-aliasing -pipe -Wall -W -Wno-unused-parameter -Wno-switch -Wno-missing-field-initializers -Wno-sign-compare -pthread -std=gnu++20 -Winvalid-pch -fpch-instantiate-templates -Xclang -emit-pch -Xclang -include -Xclang /wrkdirs/usr/ports/net-im/telegram-desktop/work/.build/Telegram/lib_base/CMakeFiles/lib_base_crash_report_writer.dir/cmake_pch.hxx -x c++-header -MD -MT Telegram/lib_base/CMakeFiles/lib_base_crash_report_writer.dir/cmake_pch.hxx.pch -MF Telegram/lib_base/CMakeFiles/lib_base_crash_report_writer.dir/cmake_pch.hxx.pch.d -o Telegram/lib_base/CMakeFiles/lib_base_crash_report_writer.dir/cmake_pch.hxx.pch -c /wrkdirs/usr/ports/net-im/telegram-desktop/work/.build/Telegram/lib_base/CMakeFiles/lib_base_crash_report_writer.dir/cmake_pch.hxx.cxx
In file included from <built-in>:1:
In file included from /wrkdirs/usr/ports/net-im/telegram-desktop/work/.build/Telegram/lib_base/CMakeFiles/lib_base_crash_report_writer.dir/cmake_pch.hxx:5:
In file included from /wrkdirs/usr/ports/net-im/telegram-desktop/work/tdesktop-3.2.5-full/Telegram/lib_base/base/base_pch.h:23:
In file included from /usr/local/include/range/v3/all.hpp:17:
In file included from /usr/local/include/range/v3/action.hpp:17:
In file included from /usr/local/include/range/v3/action/action.hpp:23:
In file included from /usr/local/include/range/v3/action/concepts.hpp:23:
In file included from /usr/local/include/range/v3/range/concepts.hpp:37:
In file included from /usr/local/include/range/v3/iterator/concepts.hpp:30:
In file included from /usr/local/include/range/v3/iterator/access.hpp:22:
/usr/local/include/std/detail/associated_types.hpp:270:60: error: too many template arguments for class template '__iterator_traits'
            &is_std_iterator_traits_specialized_impl_(std::__iterator_traits<I, B> *))[2];
                                                           ^                    ~~
/usr/include/c++/v1/__iterator/iterator_traits.h:326:8: note: template is declared here
struct __iterator_traits {};
       ^
1 error generated.
------------------------
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2021-11-25 09:12:42 UTC 
build fixes are covered by portmgr blanket approval.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-11-25 19:03:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cf108be7a7cb0ab997984a70a2192af7d7040ab0

commit cf108be7a7cb0ab997984a70a2192af7d7040ab0
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2021-11-25 18:59:53 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2021-11-25 18:59:53 +0000

    devel/range-v3: Fix installed include to work with clang13

    Import upstream patch to fix incompatibility with clang13. This
    fixes build of telegram-desktop [1] in recent head after clang13 import.

    PR:             260044, 260040 [1]
    Approved by:    build fix blanket
    Obtained from:  https://github.com/ericniebler/range-v3/commit/0487cca29e352e8f16bbd91fda38e76e39a0ed28

 devel/range-v3/Makefile                       |   1 +
 devel/range-v3/files/patch-0487cca29e35 (new) | 122 ++++++++++++++++++++++++++
 2 files changed, 123 insertions(+)
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2021-11-25 19:06:02 UTC 
(In reply to Mikael Urankar from comment #1)

Thanks for pointing this out.

Committed with blanket.