Bug 260042 - net-im/tg_owt: Installs include file incompatible with clang13 (C++20)
Summary: net-im/tg_owt: Installs include file incompatible with clang13 (C++20)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Gleb Smirnoff
URL:
Keywords:
Depends on:
Blocks: 260040 260044
  Show dependency treegraph
 
Reported: 2021-11-25 08:50 UTC by Guido Falsi
Modified: 2021-11-25 19:05 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (glebius)


Attachments
patch (1.82 KB, patch)
2021-11-25 08:50 UTC, Guido Falsi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer 2021-11-25 08:50:07 UTC
Created attachment 229721 [details]
patch

Hi,

I recently updated my system to latest HEAD and I noticed the telegram port failed to build with the error at the end of the message.

I'm attaching a patch which imports changes from upstream that fixes it.

obtained from: https://github.com/abseil/abseil-cpp/commit/e19260fd7dbef881492fd73891e0be5bd4a09b95



-------------------
FAILED: Telegram/CMakeFiles/lib_tgcalls.dir/ThirdParty/tgcalls/tgcalls/CodecSelectHelper.cpp.o 
/usr/bin/c++ -DBWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0 -DDESKTOP_APP_DISABLE_CRASH_REPORTS -DDESKTOP_APP_DISABLE_WAYLAND_INTEGRATION -DDESKTOP_APP_USE_PACKAGED -DHAVE_WEBRTC_VIDEO -DNO_MAIN_THREAD_WRAPPING -DQT_IMPLICIT_QCHAR_CONSTRUCTION -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_KEYWORDS -DRTC_DISABLE_TRACE_EVENTS -DRTC_ENABLE_VP9 -DTGCALLS_USE_STD_OPTIONAL -DWEBRTC_APM_DEBUG_DUMP=0 -DWEBRTC_APP_TDESKTOP -DWEBRTC_DUMMY_AUDIO_BUILD -DWEBRTC_ENABLE_PROTOBUF=0 -DWEBRTC_FREEBSD -DWEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE -DWEBRTC_LIBRARY_IMPL -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=1 -DWEBRTC_OPUS_SUPPORT_120MS_PTIME=1 -DWEBRTC_OPUS_VARIABLE_COMPLEXITY=0 -DWEBRTC_POSIX -DWEBRTC_USE_BUILTIN_ISAC_FLOAT -DWEBRTC_USE_H264 -DWEBRTC_USE_PIPEWIRE -DWEBRTC_USE_X11 -D_FORTIFY_SOURCE=2 -I/wrkdirs/usr/ports/net-im/telegram-desktop/work/tdesktop-3.2.5-full/Telegram/ThirdParty/tgcalls -I/wrkdirs/usr/ports/net-im/telegram-desktop/work/tdesktop-3.2.5-full/Telegram/ThirdParty/tgcalls/tgcalls -isystem /usr/local/include/tg_owt -isystem /usr/local/include/tg_owt/third_party/libyuv/include -isystem /usr/local/include/tg_owt/third_party/abseil-cpp -isystem /usr/local/include -O2 -pipe -march=nehalem -fstack-protector-strong -fno-strict-aliasing  -DNDEBUG -O2 -pipe -march=nehalem -fstack-protector-strong -fno-strict-aliasing  -DNDEBUG -Wno-deprecated-volatile -Wno-ambiguous-reversed-operator -fstack-protector-all -fstack-clash-protection -fPIC -fno-strict-aliasing -pipe -Wall -W -Wno-unused-parameter -Wno-switch -Wno-missing-field-initializers -Wno-sign-compare -std=gnu++20 -MD -MT Telegram/CMakeFiles/lib_tgcalls.dir/ThirdParty/tgcalls/tgcalls/CodecSelectHelper.cpp.o -MF Telegram/CMakeFiles/lib_tgcalls.dir/ThirdParty/tgcalls/tgcalls/CodecSelectHelper.cpp.o.d -o Telegram/CMakeFiles/lib_tgcalls.dir/ThirdParty/tgcalls/tgcalls/CodecSelectHelper.cpp.o -c /wrkdirs/usr/ports/net-im/telegram-desktop/work/tdesktop-3.2.5-full/Telegram/ThirdParty/tgcalls/tgcalls/CodecSelectHelper.cpp
In file included from /wrkdirs/usr/ports/net-im/telegram-desktop/work/tdesktop-3.2.5-full/Telegram/ThirdParty/tgcalls/tgcalls/CodecSelectHelper.cpp:1:
In file included from /wrkdirs/usr/ports/net-im/telegram-desktop/work/tdesktop-3.2.5-full/Telegram/ThirdParty/tgcalls/tgcalls/CodecSelectHelper.h:4:
In file included from /wrkdirs/usr/ports/net-im/telegram-desktop/work/tdesktop-3.2.5-full/Telegram/ThirdParty/tgcalls/tgcalls/Message.h:4:
In file included from /usr/local/include/tg_owt/api/candidate.h:20:
In file included from /usr/local/include/tg_owt/rtc_base/checks.h:57:
/usr/local/include/tg_owt/third_party/abseil-cpp/absl/meta/type_traits.h:630:35: error: no type named 'result_of' in namespace 'std'
using result_of_t = typename std::result_of<T>::type;
                    ~~~~~~~~~~~~~~^~~~~~~~~
/usr/local/include/tg_owt/third_party/abseil-cpp/absl/meta/type_traits.h:630:44: error: expected ';' after alias declaration
using result_of_t = typename std::result_of<T>::type;
                                           ^
2 errors generated.
------------------------
Comment 1 commit-hook freebsd_committer 2021-11-25 19:03:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c88ab801382cef0e6d65740a390cc9bbdac99eae

commit c88ab801382cef0e6d65740a390cc9bbdac99eae
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2021-11-25 18:55:29 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2021-11-25 18:59:35 +0000

    net-im/tg_owt: Fix installed include to work with clang13

    Import code from upstream fixing an issue in an installed include
    file causing telegram-desktop [1] to fail to build on recent head after
    the import of clang13.

    PR:             260042, 260040 [1]
    Approved by:    build fix blanket
    Obtained from:  https://github.com/abseil/abseil-cpp/commit/e19260fd7dbef881492fd73891e0be5bd4a09b95

 net-im/tg_owt/Makefile                             |  2 +-
 ...party_abseil-cpp_absl_meta_type__traits.h (new) | 30 ++++++++++++++++++++++
 2 files changed, 31 insertions(+), 1 deletion(-)
Comment 2 Guido Falsi freebsd_committer 2021-11-25 19:05:43 UTC
Committed with blanket.