Bug 260596

Summary: devel/gn: drop -T from flags passed to ar
Product: Ports & Packages Reporter: Oleh Hushchenkov <o.hushchenkov>
Component: Individual Port(s)Assignee: Li-Wen Hsu <lwhsu>
Status: Closed FIXED    
Severity: Affects Only Me CC: emaste, lwhsu, o.hushchenkov
Priority: --- Keywords: patch
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 260523    
Attachments:
Description Flags
Patch o.hushchenkov: maintainer-approval+

Description Oleh Hushchenkov 2021-12-21 21:07:30 UTC
Created attachment 230295 [details]
Patch

Remove -T flag from arguments passed to ar, because of planned -T flag removal from ar in base and misusing. For now, switch to OpenBSD's build template. The only difference with previously used Linux's build template is this -T switch. NetBSD still use Linux's build template.
Comment 1 Ed Maste freebsd_committer freebsd_triage 2021-12-22 01:44:01 UTC
patch LGTM, we could switch back in the future once base ar supports -T for thin
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-12-22 12:49:50 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=645a63cd63bf7d0aa8315b351e002b4c801cd5e1

commit 645a63cd63bf7d0aa8315b351e002b4c801cd5e1
Author:     Oleh Hushchenkov <o.hushchenkov@gmail.com>
AuthorDate: 2021-12-22 12:44:53 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2021-12-22 12:48:50 +0000

    devel/gn: Drop -T from flags passed to ar

    Remove -T flag from arguments passed to ar, because of planned -T flag
    removal from ar in base and misusing. For now, switch to OpenBSD's build
    template. The only difference with previously used Linux's build
    template is this -T switch. NetBSD still use Linux's build template.

    PR:             260596
    Reviewed by:    emaste

 devel/gn/Makefile                 |  1 +
 devel/gn/files/patch-build_gen.py | 11 ++++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)