Bug 260596 - devel/gn: drop -T from flags passed to ar
Summary: devel/gn: drop -T from flags passed to ar
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords: patch
Depends on:
Blocks: 260523
  Show dependency tree / graph
 
Reported: 2021-12-21 21:07 UTC by Oleh Hushchenkov
Modified: 2021-12-29 23:57 UTC (History)
3 users (show)

See Also:

Attachments
Patch (1.26 KB, patch)
2021-12-21 21:07 UTC, Oleh Hushchenkov 		o.hushchenkov: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleh Hushchenkov 2021-12-21 21:07:30 UTC 
Created attachment 230295 [details]
Patch

Remove -T flag from arguments passed to ar, because of planned -T flag removal from ar in base and misusing. For now, switch to OpenBSD's build template. The only difference with previously used Linux's build template is this -T switch. NetBSD still use Linux's build template.
Comment 1 Ed Maste freebsd_committer freebsd_triage 2021-12-22 01:44:01 UTC 
patch LGTM, we could switch back in the future once base ar supports -T for thin
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-12-22 12:49:50 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=645a63cd63bf7d0aa8315b351e002b4c801cd5e1

commit 645a63cd63bf7d0aa8315b351e002b4c801cd5e1
Author:     Oleh Hushchenkov <o.hushchenkov@gmail.com>
AuthorDate: 2021-12-22 12:44:53 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2021-12-22 12:48:50 +0000

    devel/gn: Drop -T from flags passed to ar

    Remove -T flag from arguments passed to ar, because of planned -T flag
    removal from ar in base and misusing. For now, switch to OpenBSD's build
    template. The only difference with previously used Linux's build
    template is this -T switch. NetBSD still use Linux's build template.

    PR:             260596
    Reviewed by:    emaste

 devel/gn/Makefile                 |  1 +
 devel/gn/files/patch-build_gen.py | 11 ++++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)