Bug 262659
| Summary: | textproc/py-sphinx-autodoc-typehints: Update to 1.18.3 | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andreas Bilke <andreas> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | Nuno Teixeira <eduardo> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Only Me | CC: | andreas, eduardo | ||||||||||||||
| Priority: | --- | ||||||||||||||||
| Version: | Latest | ||||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| URL: | https://github.com/tox-dev/sphinx-autodoc-typehints/blob/1.18.3/CHANGELOG.md | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 262682 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 232589 [details]
Patch for updating and renaming package
Created attachment 235449 [details]
Update to 1.18.3
(In reply to Andreas Bilke from comment #0) project name didn't change: sphinx-autodoc-typehints (In reply to Nuno Teixeira from comment #3) That's true but if I keep the old port name it tries to download from pypi with the URL https://pypi.org/packages/source/s/sphinx-autodoc-typehints/sphinx-autodoc-typehints-1.18.3.tar.gz which does not exists (but the underscore version does). Is there a good way to tackle this problem? (In reply to Andreas Bilke from comment #4) https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-distname Created attachment 235468 [details]
Update to 1.18.3
(In reply to Nuno Teixeira from comment #5) Thank you for pointing me to this. I updated the patch file (removing the renaming, introducing DISTNAME). Is this the way how it should be? Created attachment 235469 [details]
Update to 1.18.3 - Fixed
- switch to DISTVERSION
- update WWW (redirects)
(In reply to Andreas Bilke from comment #7) Yes, thats correct way to do it. Sorry I put your patch obsoleted. DISTNAME= sphinx_autodoc_typehints-${DISTVERSION} is enough. Created attachment 235470 [details]
Update to 1.18.3 - Final
Please set approval on details of patch so I can commit. Cheers Sorry for not being the brightest today but I can't change the flag for "eduardo: maintainer-approval?" My changes are not saved. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=af3565c3cd51a8959fcc878ed9aeb04e09d65f34 commit af3565c3cd51a8959fcc878ed9aeb04e09d65f34 Author: Andreas Bilke <andreas@bilke.org> AuthorDate: 2022-07-25 17:33:45 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-07-25 17:35:23 +0000 textproc/py-sphinx-autodoc-typehints: Update to 1.18.3 - switch to DISTVERSION - update WWW (redirect) ChangeLog: https://github.com/tox-dev/sphinx-autodoc-typehints/blob/1.18.3/CHANGELOG.md PR: 262659 textproc/py-sphinx-autodoc-typehints/Makefile | 15 ++++++++------- textproc/py-sphinx-autodoc-typehints/distinfo | 6 +++--- textproc/py-sphinx-autodoc-typehints/pkg-descr | 2 +- 3 files changed, 12 insertions(+), 11 deletions(-) Committed, thanks! |
Created attachment 232570 [details] Patch for updating and renaming package. The following changes were made: - Upstream of package changed (fix URLs) - Package was renamed by upstream (replaces dashes by underscores) - Update to latest version 1.17.0 (+ update dependencies) I hope this is the correct approach of upstream changes package names.