Bug 262659 - textproc/py-sphinx-autodoc-typehints: Update to 1.18.3
Summary: textproc/py-sphinx-autodoc-typehints: Update to 1.18.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/tox-dev/sphinx-aut...
Keywords:
Depends on:
Blocks: 262682
  Show dependency tree / graph
 
Reported: 2022-03-19 09:43 UTC by Andreas Bilke
Modified: 2022-07-25 17:36 UTC (History)
2 users (show)

See Also:

Attachments
Patch for updating and renaming package. (2.92 KB, patch)
2022-03-19 09:43 UTC, Andreas Bilke 		andreas: maintainer-approval+
Details | Diff
Patch for updating and renaming package (3.36 KB, patch)
2022-03-20 12:42 UTC, Andreas Bilke 		andreas: maintainer-approval+
Details | Diff
Update to 1.18.3 (3.36 KB, patch)
2022-07-24 07:37 UTC, Andreas Bilke 		andreas: maintainer-approval+
Details | Diff
Update to 1.18.3 (2.20 KB, patch)
2022-07-25 15:49 UTC, Andreas Bilke 		andreas: maintainer-approval+
Details | Diff
Update to 1.18.3 - Fixed (2.53 KB, patch)
2022-07-25 15:57 UTC, Nuno Teixeira 		no flags Details | Diff
Update to 1.18.3 - Final (2.81 KB, patch)
2022-07-25 16:11 UTC, Nuno Teixeira 		eduardo: maintainer-approval?
Details | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Bilke 2022-03-19 09:43:13 UTC 
Created attachment 232570 [details]
Patch for updating and renaming package.

The following changes were made:

- Upstream of package changed (fix URLs)
- Package was renamed by upstream (replaces dashes by underscores)
- Update to latest version 1.17.0 (+ update dependencies)

I hope this is the correct approach of upstream changes package names.
Comment 1 Andreas Bilke 2022-03-20 12:42:07 UTC 
Created attachment 232589 [details]
Patch for updating and renaming package
Comment 2 Andreas Bilke 2022-07-24 07:37:40 UTC 
Created attachment 235449 [details]
Update to 1.18.3
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-24 17:56:02 UTC 
(In reply to Andreas Bilke from comment #0)

project name didn't change: sphinx-autodoc-typehints
Comment 4 Andreas Bilke 2022-07-25 14:54:54 UTC 
(In reply to Nuno Teixeira from comment #3)

That's true but if I keep the old port name it tries to download from pypi with the URL https://pypi.org/packages/source/s/sphinx-autodoc-typehints/sphinx-autodoc-typehints-1.18.3.tar.gz
 which does not exists (but the underscore version does).

Is there a good way to tackle this problem?
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-25 15:20:16 UTC 
(In reply to Andreas Bilke from comment #4)

https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-distname
Comment 6 Andreas Bilke 2022-07-25 15:49:17 UTC 
Created attachment 235468 [details]
Update to 1.18.3
Comment 7 Andreas Bilke 2022-07-25 15:49:51 UTC 
(In reply to Nuno Teixeira from comment #5)

Thank you for pointing me to this. I updated the patch file (removing the renaming, introducing DISTNAME). Is this the way how it should be?
Comment 8 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-25 15:57:40 UTC 
Created attachment 235469 [details]
Update to 1.18.3 - Fixed

- switch to DISTVERSION
- update WWW (redirects)
Comment 9 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-25 16:05:16 UTC 
(In reply to Andreas Bilke from comment #7)
Yes, thats correct way to do it.

Sorry I put your patch obsoleted.

DISTNAME= sphinx_autodoc_typehints-${DISTVERSION} is enough.
Comment 10 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-25 16:11:34 UTC 
Created attachment 235470 [details]
Update to 1.18.3 - Final
Comment 11 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-25 16:12:52 UTC 
Please set approval on details of patch so I can commit.

Cheers
Comment 12 Andreas Bilke 2022-07-25 16:40:00 UTC 
Sorry for not being the brightest today but I can't change the flag for "eduardo: maintainer-approval?" My changes are not saved.
Comment 13 commit-hook freebsd_committer freebsd_triage 2022-07-25 17:35:50 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=af3565c3cd51a8959fcc878ed9aeb04e09d65f34

commit af3565c3cd51a8959fcc878ed9aeb04e09d65f34
Author:     Andreas Bilke <andreas@bilke.org>
AuthorDate: 2022-07-25 17:33:45 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-07-25 17:35:23 +0000

    textproc/py-sphinx-autodoc-typehints: Update to 1.18.3

     - switch to DISTVERSION
     - update WWW (redirect)

    ChangeLog:      https://github.com/tox-dev/sphinx-autodoc-typehints/blob/1.18.3/CHANGELOG.md
    PR:             262659

 textproc/py-sphinx-autodoc-typehints/Makefile  | 15 ++++++++-------
 textproc/py-sphinx-autodoc-typehints/distinfo  |  6 +++---
 textproc/py-sphinx-autodoc-typehints/pkg-descr |  2 +-
 3 files changed, 12 insertions(+), 11 deletions(-)
Comment 14 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-25 17:36:59 UTC 
Committed, thanks!