Bug 270370

Summary: net/babeld: update to 1.13.1
Product: Ports & Packages Reporter: Hung-Yi Chen <gaod>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Open ---    
Severity: Affects Only Me CC: eduardo
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/jech/babeld/blob/babeld-1.13.1/CHANGES
Attachments:
Description Flags
babeld 1.12.2
gaod: maintainer-approval-
babeld 1.12.2
none
babeld 1.13.1 none

Description Hung-Yi Chen 2023-03-20 19:18:38 UTC
Created attachment 241018 [details]
babeld 1.12.2

* Update to 1.12.2
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2023-03-26 19:38:35 UTC
Hello,

Seams that port doesn't respect CFLAGS, shouldn't MAKE_ARGS include it?
Does it need debug flags by default?

MAKE_ARGS=      CDEBUGFLAGS="${CFLAGS} -O2 -g -Wall"

https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags

+ Define LICENSE_FILE

https://docs.freebsd.org/en/books/porters-handbook/book/#licenses-license

Cheers
Comment 2 Hung-Yi Chen 2023-03-27 06:37:15 UTC
Thanks for your kind reminder.

Just attach a new patch.
Comment 3 Hung-Yi Chen 2023-03-27 06:37:51 UTC
Created attachment 241140 [details]
babeld 1.12.2
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2023-03-27 07:39:42 UTC
(In reply to Hung-Yi Chen from comment #3)

From ${WRKSRC}/Makefile:

---
CDEBUGFLAGS = -Os -g -Wall
CFLAGS = $(CDEBUGFLAGS) $(DEFINES) $(EXTRA_DEFINES)
---

Compiling still not respect CFLAGS:
---
cc  -Os -g -Wall   -c net.c -o net.o
---

Sugestion is to use:
---
MAKE_ARGS=      CFLAGS+="${CFLAGS}"
---
result:
---
cc  -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -c net.c -o net.o
---
and if really needed debug compiling there is the possibility of adding a DEBUG option.

While we are here:

- Switch PORTVERSION -> DISTVERSION

Could you please test it?
Comment 5 Hung-Yi Chen 2024-05-05 12:30:31 UTC
Created attachment 250437 [details]
babeld 1.13.1

* Update to 1.13.1
* Add LICENSE_FILE
* Lint Makefile