Bug 270370 - net/babeld: update to 1.13.1
Summary: net/babeld: update to 1.13.1
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/jech/babeld/blob/b...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-20 19:18 UTC by Hung-Yi Chen
Modified: 2024-05-05 12:30 UTC (History)
1 user (show)

See Also:


Attachments
babeld 1.12.2 (1.10 KB, patch)
2023-03-20 19:18 UTC, Hung-Yi Chen
gaod: maintainer-approval-
Details | Diff
babeld 1.12.2 (1.22 KB, patch)
2023-03-27 06:37 UTC, Hung-Yi Chen
no flags Details | Diff
babeld 1.13.1 (1.83 KB, patch)
2024-05-05 12:30 UTC, Hung-Yi Chen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hung-Yi Chen 2023-03-20 19:18:38 UTC
Created attachment 241018 [details]
babeld 1.12.2

* Update to 1.12.2
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2023-03-26 19:38:35 UTC
Hello,

Seams that port doesn't respect CFLAGS, shouldn't MAKE_ARGS include it?
Does it need debug flags by default?

MAKE_ARGS=      CDEBUGFLAGS="${CFLAGS} -O2 -g -Wall"

https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags

+ Define LICENSE_FILE

https://docs.freebsd.org/en/books/porters-handbook/book/#licenses-license

Cheers
Comment 2 Hung-Yi Chen 2023-03-27 06:37:15 UTC
Thanks for your kind reminder.

Just attach a new patch.
Comment 3 Hung-Yi Chen 2023-03-27 06:37:51 UTC
Created attachment 241140 [details]
babeld 1.12.2
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2023-03-27 07:39:42 UTC
(In reply to Hung-Yi Chen from comment #3)

From ${WRKSRC}/Makefile:

---
CDEBUGFLAGS = -Os -g -Wall
CFLAGS = $(CDEBUGFLAGS) $(DEFINES) $(EXTRA_DEFINES)
---

Compiling still not respect CFLAGS:
---
cc  -Os -g -Wall   -c net.c -o net.o
---

Sugestion is to use:
---
MAKE_ARGS=      CFLAGS+="${CFLAGS}"
---
result:
---
cc  -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -c net.c -o net.o
---
and if really needed debug compiling there is the possibility of adding a DEBUG option.

While we are here:

- Switch PORTVERSION -> DISTVERSION

Could you please test it?
Comment 5 Hung-Yi Chen 2024-05-05 12:30:31 UTC
Created attachment 250437 [details]
babeld 1.13.1

* Update to 1.13.1
* Add LICENSE_FILE
* Lint Makefile