Bug 271524

Summary:	net/dpdk: Fix build with -Wstrict-prototypes
Product:	Ports & Packages	Reporter:	John Baldwin <jhb>
Component:	Individual Port(s)	Assignee:	John Baldwin <jhb>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	bruce.richardson, fernape, freebsd, fuz
Priority:	---	Flags:	bugzilla: maintainer-feedback? (bruce.richardson)
Version:	Latest
Hardware:	Any
OS:	Any

Description John Baldwin freebsd_committer

2023-05-20 00:56:54 UTC

Patch available at https://reviews.freebsd.org/D40170

Comment 1 Mina Galić freebsd_triage

2023-05-20 05:17:50 UTC

upstream doesn't seem to know about this one yet https://bugs.dpdk.org/buglist.cgi?quicksearch=function%20declaration%20without%20a%20prototype%20is%20deprecated%20in%20all%20versions%20of%20C%20

Comment 2 Robert Clausecker freebsd_committer

2023-05-20 20:45:51 UTC

Build fixes like these are subject to portmgr's build fix blanket approval and do not require specific maintainer approval.

Comment 3 Bruce Richardson 2023-05-22 07:54:51 UTC

LGTM.

I will submit patch for upstream to match.

Comment 4 Fernando Apesteguía freebsd_committer

2023-05-22 08:03:03 UTC

^Triage: reporter is committer, assign accordingly.

Comment 5 John Baldwin freebsd_committer

2023-05-23 21:34:47 UTC

Forgot to tag the commit, but this was merged:

commit 74c810e22221e95130124559aaeb5e7a384360dc
Author: John Baldwin <jhb@FreeBSD.org>
Date:   Tue May 23 14:27:26 2023 -0700

    net/dpdk*: Use valid prototypes for function declarations with no arguments.
    
    Reviewed by:    fuz, Bruce Richardson (maintainer)
    Differential Revision:  https://reviews.freebsd.org/D40170