Bug 272749
| Summary: | ndp(8): correct a few xo_emit formats | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Helge Oldach <freebsd> | ||||||||
| Component: | bin | Assignee: | Zhenlei Huang <zlei> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | freebsd, freebsd, zlei | ||||||||
| Priority: | --- | Keywords: | ipv6, patch | ||||||||
| Version: | 14.1-STABLE | Flags: | zlei:
mfc-stable14+
zlei: mfc-stable13+ |
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| URL: | https://reviews.freebsd.org/D35677 | ||||||||||
| Attachments: |
|
||||||||||
Hi Helge, i know this is a pretty trivial patch, but we're trying to get rid of src patches in Bugzilla. Unlike ports, there's no established process to get them committed quickly, and bugzilla has no review system like Phabricator (https://reviews.freebsd.org/) or Github (https://github.com/freebsd/freebsd-src) See https://docs.freebsd.org/en/articles/contributing/ for more info. in general: Patches are made against the "main" branch, and then MFC'd down to stable. I mention this because this bug is open against Version 13.2-STABLE. Either way, I'm assigning this to net@ now. I forgot to add that this patch applies cleanly to main (with fuzz and offset though). Created attachment 244806 [details]
patch
Added a correction for the ts_print function as well.
Created attachment 253269 [details]
few things have been patched but these trivial corrections are still missing
Revised patch
(In reply to Helge Oldach from comment #4) Thanks for the patch. This should be regression by https://reviews.freebsd.org/D35677 . I'll take look at it. Looks good to me. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=209905ec384eedd58f1b9b7ab774029d22787dfb commit 209905ec384eedd58f1b9b7ab774029d22787dfb Author: Helge Oldach <freebsd@oldach.net> AuthorDate: 2024-09-02 10:12:43 +0000 Commit: Zhenlei Huang <zlei@FreeBSD.org> CommitDate: 2024-09-02 10:15:15 +0000 ndp: Fix libxo formatting for the header of neighbor cache PR: 272749 Reviewed by: zlei Fixes: e1c7783e220b ndp(8): add structured output formatting via libxo Fixes: 91fbe0819bb9 ndp: convert ndp(8) to netlink MFC after: 3 days usr.sbin/ndp/ndp.c | 2 +- usr.sbin/ndp/ndp_netlink.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Gentle MFC reminder... A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=07cf1ce012c51e30ef5078c23a7d68a9b5d87c0a commit 07cf1ce012c51e30ef5078c23a7d68a9b5d87c0a Author: Helge Oldach <freebsd@oldach.net> AuthorDate: 2024-09-02 10:12:43 +0000 Commit: Zhenlei Huang <zlei@FreeBSD.org> CommitDate: 2024-09-10 10:01:49 +0000 ndp: Fix libxo formatting for the header of neighbor cache PR: 272749 Reviewed by: zlei Fixes: e1c7783e220b ndp(8): add structured output formatting via libxo Fixes: 91fbe0819bb9 ndp: convert ndp(8) to netlink MFC after: 3 days (cherry picked from commit 209905ec384eedd58f1b9b7ab774029d22787dfb) usr.sbin/ndp/ndp.c | 2 +- usr.sbin/ndp/ndp_netlink.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=818a8f2ef34408e2e85d9317e67492fa165bd98a commit 818a8f2ef34408e2e85d9317e67492fa165bd98a Author: Helge Oldach <freebsd@oldach.net> AuthorDate: 2024-09-02 10:12:43 +0000 Commit: Zhenlei Huang <zlei@FreeBSD.org> CommitDate: 2024-09-11 10:07:48 +0000 ndp: Fix libxo formatting for the header of neighbor cache PR: 272749 Reviewed by: zlei Fixes: e1c7783e220b ndp(8): add structured output formatting via libxo MFC after: 3 days (Note this is only a partial MFS, as the netlink part was not MFS'ed) (cherry picked from commit 209905ec384eedd58f1b9b7ab774029d22787dfb) (cherry picked from commit 07cf1ce012c51e30ef5078c23a7d68a9b5d87c0a) usr.sbin/ndp/ndp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) |
Created attachment 243638 [details] patch Fix are a few incorrect xo_emit formats which are hiding useful printout for ndp -p and ndp -a.