Bug 274635

Summary: lang/ldc: Update to 1.35.0
Product: Ports & Packages Reporter: Gleb Popov <arrowd>
Component: Ports FrameworkAssignee: Jose Alonso Cardenas Marquez <acm>
Status: Closed FIXED    
Severity: Affects Only Me CC: acm, pkubaj, ports-bugs
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 272994    
Bug Blocks:    
Attachments:
Description Flags
Patch arrowd: maintainer-approval? (acm)

Description Gleb Popov freebsd_committer freebsd_triage 2023-10-21 18:56:43 UTC
Created attachment 245787 [details]
Patch
Comment 1 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-10-21 19:04:21 UTC
Any specific reason to assign this to portmgr@ like do you need an exp-run or something else?
Comment 2 Gleb Popov freebsd_committer freebsd_triage 2023-10-21 19:17:43 UTC
I don't remember requesting an exprun for previous updates. Anyways, it is up to maintainer.
Comment 3 Gleb Popov freebsd_committer freebsd_triage 2023-10-21 19:18:22 UTC
Ah, not sure how did I set this field incorrectly. Sorry.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-11-14 12:10:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bcdb7925cac781f8447e343a285ea5ce59bb3d51

commit bcdb7925cac781f8447e343a285ea5ce59bb3d51
Author:     Gleb Popov <arrowd@FreeBSD.org>
AuthorDate: 2023-10-21 18:49:44 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2023-11-14 12:08:42 +0000

    lang/ldc: Update to 1.35.0 and switch to using binary bootstrap.

    PR:             274635
    Approved by:    acm (maintainer timeout)

 lang/ldc/Makefile                                  | 41 ++++++++--------------
 lang/ldc/distinfo                                  |  8 +++--
 ...-runtime_druntime_src_core_sys_freebsd_config.d | 16 +++++----
 lang/ldc/pkg-plist                                 | 22 +++++++-----
 4 files changed, 43 insertions(+), 44 deletions(-)
Comment 5 Piotr Kubaj freebsd_committer freebsd_triage 2023-11-14 12:27:53 UTC
Why switch to using a binary bootstrap? Before this port worked fine on powerpc* architectures, now it requires a bootstrap. How to generate it?
Comment 6 Gleb Popov freebsd_committer freebsd_triage 2023-11-14 12:41:43 UTC
(In reply to Piotr Kubaj from comment #5)
Not sure how did it work on powerpc, since it was completely broken due to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274627

At the same time, bootstrapping ldc is only possible with gcc11, because gcc12 also requires bootstrapping for the D support. So in the end, we'll eventually go the bootstrapping path anyways. I decided to at least fix D for the tier1 platform.
Comment 7 Piotr Kubaj freebsd_committer freebsd_triage 2023-11-14 12:53:16 UTC
It worked on 13.2.

Can you post instructions how to generate the bootstrap?
It could also be added to the Makefile.
Comment 8 Gleb Popov freebsd_committer freebsd_triage 2023-11-14 12:56:55 UTC
(In reply to Piotr Kubaj from comment #7)
I believe, the package itself can be easily adapted to be used as a bootstrap. It only needs to be extracted into ${WRKDIR}