Bug 276259

Summary: Mk/*: unconditionally use .MAKE.UID and .MAKE.GID
Product: Ports & Packages Reporter: Christian Weisgerber <naddy>
Component: Ports FrameworkAssignee: Port Management Team <portmgr>
Status: Closed FIXED    
Severity: Affects Only Me CC: arrowd, leres, ports-bugs
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
unconditionally use .MAKE.UID and .MAKE.GID arrowd: maintainer-approval+

Description Christian Weisgerber freebsd_committer freebsd_triage 2024-01-11 15:13:52 UTC
Created attachment 247596 [details]
unconditionally use .MAKE.UID and .MAKE.GID

Since FreeBSD 12 has been EOLed, the built-in make(1) variables .MAKE.UID and .MAKE.GID are always available.
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2024-01-11 17:50:54 UTC
The change looks OK.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-01-15 16:18:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fe3392ed8d428ccb922ea60097e4cac7c95ad07a

commit fe3392ed8d428ccb922ea60097e4cac7c95ad07a
Author:     Christian Weisgerber <naddy@FreeBSD.org>
AuthorDate: 2024-01-11 14:53:35 +0000
Commit:     Christian Weisgerber <naddy@FreeBSD.org>
CommitDate: 2024-01-15 16:17:05 +0000

    Mk/*: unconditionally use .MAKE.UID and .MAKE.GID

    Since FreeBSD 12 has been EOLed, the built-in make(1) variables
    .MAKE.UID and .MAKE.GID are always available.

    PR:             276259
    Approved by:    arrowd

 Mk/Uses/uidfix.mk     | 4 +---
 Mk/bsd.port.mk        | 8 +-------
 Mk/bsd.port.subdir.mk | 4 +---
 3 files changed, 3 insertions(+), 13 deletions(-)
Comment 3 Craig Leres freebsd_committer freebsd_triage 2024-01-15 17:50:49 UTC
While this is a good change to make, poudriere sets UID in the environment:

zinc 201 # poudriere bulk -i -j 13release -p current ports-mgmt/pkg
[00:00:00] Creating the reference jail... done
[...]
[00:00:12] Entering interactive test mode. Type 'exit' when done.
nobody@zinc:/usr/ports/ports-mgmt/pkg % cd /usr/ports/ports-mgmt/pkg
nobody@zinc:/usr/ports/ports-mgmt/pkg % make -V UID
0
nobody@zinc:/usr/ports/ports-mgmt/pkg % make -V .MAKE.UID
65534