Bug 277004
| Summary: | print/lilypond: add option for using lang/guile3 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Martin Neubauer <m.ne> | ||||||
| Component: | Individual Port(s) | Assignee: | Muhammad Moinur Rahman <bofh> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | bofh | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277001 | ||||||||
| Attachments: |
|
||||||||
I think this will be a bit misleading. This should be done with OPTIONS_SINGLE and presenting both the option GUILE2 and GUILE3. Rethink and let me know your rationale. (In reply to Muhammad Moinur Rahman from comment #1) After doing some testing with OPTIONS_SINGLE I have to agree that this is a clearly better setup. I therefore updated the patch that way. For the original patch I just reintroduced an option I had implemented several years ago. Back then guile 1 was used, with newer support for guile 2 still considered experimental by upstream. In that situation, having a single switch made more sense (and I would defend that decision even today.) Today, with guile 2 and 3 supported more or less equally, OPTIONS_SINGLE etc. does indeed make more sense. Created attachment 248398 [details]
alternative patch
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c7c803faf8aa3a7e324492282ccdd36c0d8577a6 commit c7c803faf8aa3a7e324492282ccdd36c0d8577a6 Author: Martin Neubauer <m.ne@gmx.net> AuthorDate: 2024-02-12 17:26:36 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2024-02-12 17:38:58 +0000 print/lilypond: Optionize GUILE versions PR: 277004 Approved by: submitter is maintainer print/lilypond/Makefile | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) |
Created attachment 248395 [details] patch adding optional guile3dependency The last stable release included support for Guile 3.0, with version 2 still being the default. Adding an option to keep the port in line with print/lilypnd-devel (just with different defaults.)