Bug 277004 - print/lilypond: add option for using lang/guile3
Summary: print/lilypond: add option for using lang/guile3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-12 14:18 UTC by Martin Neubauer
Modified: 2024-02-12 17:41 UTC (History)
1 user (show)

See Also:


Attachments
patch adding optional guile3dependency (1.05 KB, patch)
2024-02-12 14:18 UTC, Martin Neubauer
m.ne: maintainer-approval+
Details | Diff
alternative patch (1006 bytes, patch)
2024-02-12 17:07 UTC, Martin Neubauer
m.ne: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Neubauer 2024-02-12 14:18:45 UTC
Created attachment 248395 [details]
patch adding optional guile3dependency

The last stable release included support for Guile 3.0, with version 2 still being the default. Adding an option to keep the port in line with print/lilypnd-devel (just with different defaults.)
Comment 1 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2024-02-12 15:58:40 UTC
I think this will be a bit misleading. This should be done with OPTIONS_SINGLE and presenting both the option GUILE2 and GUILE3. Rethink and let me know your rationale.
Comment 2 Martin Neubauer 2024-02-12 17:06:38 UTC
(In reply to Muhammad Moinur Rahman from comment #1)
After doing some testing with OPTIONS_SINGLE I have to agree that this is a clearly better setup. I therefore updated the patch that way.

For the original patch I just reintroduced an option I had implemented several years ago. Back then guile 1 was used, with newer support for guile 2 still considered experimental by upstream. In that situation, having a single switch made more sense (and I would defend that decision even today.) Today, with guile 2 and 3 supported more or less equally, OPTIONS_SINGLE etc. does indeed make more sense.
Comment 3 Martin Neubauer 2024-02-12 17:07:53 UTC
Created attachment 248398 [details]
alternative patch
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-02-12 17:40:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c7c803faf8aa3a7e324492282ccdd36c0d8577a6

commit c7c803faf8aa3a7e324492282ccdd36c0d8577a6
Author:     Martin Neubauer <m.ne@gmx.net>
AuthorDate: 2024-02-12 17:26:36 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2024-02-12 17:38:58 +0000

    print/lilypond: Optionize GUILE versions

    PR:             277004
    Approved by:    submitter is maintainer

 print/lilypond/Makefile | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)