Bug 277040
| Summary: | audio/quimup: Update to 2.0.1 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jason E. Hale <jhale> | ||||||||
| Component: | Individual Port(s) | Assignee: | Jason E. Hale <jhale> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | cmangin, fuz | ||||||||
| Priority: | --- | Flags: | cmangin:
maintainer-feedback+
|
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 276677 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jason E. Hale
2024-02-14 00:49:25 UTC
Created attachment 248463 [details]
v2
Hello,
I reviewed the patch and made the following changes:
- Add a dependency to qt6-svg. The buttons wont be displayed properly without it.
- Specify the correct path for the musicpd binary in qm_mpdcom.cpp
This PR is approved.
Thanks!
^Triage: deassign to non-committer. maintainer-feedback+ is sufficient here. Is there a changelog for this update? Sorry I got behind on this. I found out the settings don’t save correctly, but I have a fix for it. I’ll upload it when I get home. There’s a changelog on the project page: https://sourceforge.net/projects/quimup/files/Quimup%202.0/ Created attachment 250482 [details]
v3
This applies the maintainer's fixes, but I made qt6-svg a runtime dependency since it is not linked to. It still bothered me that the autoconfig didn't work out of the box. To be fair, it didn't work quite right in 1.4.4 either, but I wrongfully ignored this in my initial patch. I mostly fixed it so the application now correctly populates the fields in Settings->Connect (Connection profile) with settings found primarily in a local mpd.conf (~/.config/mpd/mpd.conf) or secondarily in the global /usr/local/etc/mpd.conf.
The remaining issue is that the settings dialog falsely reports that the musicpd daemon isn't running when it actually is, but this only seems to be the case when musicpd is launched at the system level. When the "Connect now" button is pressed in the Settings->Connect menu, however, the correct information is updated and displayed. This does not seem to be the case when quimup launches its own musicpd instance, as all information displays as one would expect. The previous version didn't display information on whether the server was running, so I wouldn't consider it a regression, but a bug in a new feature.
Chris, your quick response and insight were much appreciated. Again, I apologize for sitting on this.
Jason, this seems to be a minor bug from the application. I observed it on multiple configurations. (system/user, tcp, unix socket) I think we can go forward with this PR. A changelog can be downloaded at https://sourceforge.net/projects/quimup/files/Quimup%202.0/changelog/download Thanks! (In reply to Chris Mangin from comment #6) Cool. Unfortunately, upstream hasn't published their repository and doesn't seem to have any bug reporting mechanism available, so I guess we'll just keep these changes as local patches. Cover art updating could use some looking into, as well. Thanks for taking this and lighting a fire under my nether regions, fuz, but I'm assigning this bug to myself since I started it. Hi Jason, I took this issue as it seemed like you dropped the ball on it and it was unclear if you still wanted to work on it. No problem with you taking it back! (In reply to Robert Clausecker from comment #8) Understandable, and I did very much drop the ball here and still feel really bad about letting this sit so long, especially with a very responsive and insightful maintainer, such as Chris. The taglib update, however, has been put on the back burner as I've been simply overwhelmed with my duties on kde@ keeping Qt* and CMake up to snuff, but this update is a step closer. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b52b8d1282d22fc37f23df2fe42aaf5e0a3bb5b6 commit b52b8d1282d22fc37f23df2fe42aaf5e0a3bb5b6 Author: Jason E. Hale <jhale@FreeBSD.org> AuthorDate: 2024-02-13 23:06:41 +0000 Commit: Jason E. Hale <jhale@FreeBSD.org> CommitDate: 2024-05-06 09:31:04 +0000 audio/quimup: Update to 2.0.1 Update WWW and LICENSE (GPLv3+) according to upstream. Switch build to Qt6 as upstream has dropped support of Qt5. Pet portclippy(1). PR: 277040 Approved by: Chris Mangin <cmangin@arobas.net> (maintainer) audio/quimup/Makefile | 42 +++---- audio/quimup/distinfo | 6 +- .../quimup/files/patch-source_qm__config.cpp (new) | 14 +++ .../quimup/files/patch-source_qm__itemlist.h (new) | 11 ++ .../quimup/files/patch-source_qm__mpdcom.cpp (new) | 128 +++++++++++++++++++++ audio/quimup/files/patch-src_qm__config.cpp (gone) | 14 --- audio/quimup/files/patch-src_qm__itemlist.h (gone) | 11 -- audio/quimup/files/patch-src_qm__mpdcom.cpp (gone) | 55 --------- 8 files changed, 175 insertions(+), 106 deletions(-) quimup 2.0.1 had landed. Sorry again for the delays. |