Bug 277040 - audio/quimup: Update to 2.0.1
Summary: audio/quimup: Update to 2.0.1
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks: 276677
  Show dependency treegraph
 
Reported: 2024-02-14 00:49 UTC by Jason E. Hale
Modified: 2024-02-19 07:14 UTC (History)
1 user (show)

See Also:
cmangin: maintainer-feedback+


Attachments
v1 (13.14 KB, patch)
2024-02-14 00:49 UTC, Jason E. Hale
no flags Details | Diff
v2 (13.13 KB, patch)
2024-02-14 17:01 UTC, Chris Mangin
cmangin: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason E. Hale freebsd_committer freebsd_triage 2024-02-14 00:49:25 UTC
Created attachment 248450 [details]
v1

Build tested on:
FreeBSD 13.2-i386
FreeBSD 15.0-CURRENT

Run tested on:
FreeBSD 15.0-CURRENT

The main goal for this update is to drop audio/taglib from LIB_DEPENDS from audio/quimup in pursuant to bug#276677, since quimup 1.4.x is incompatible with taglib 2.x and quimup 2.0.x doesn't depend on taglib at all.

Upstream has also migrated to Qt6, which is really great for quimup's sustainability within the FreeBSD ports tree as Qt5 support is slowly coming to a close.

I'm not a regular musicpd user and don't pretend to have a full grasp on it, but I tried to do my due diligence by setting up a basic mpd server and running some A/B tests to make sure the quimup application ran similarly to the previous version. After tweaking quimup a bit to get it to acknowledge my musicpd installation, especially when it launches its own instance of musicpd, I have found it to exit cleaner than the previous version, but would appreciate maintainer input.
Comment 1 Chris Mangin 2024-02-14 17:01:17 UTC
Created attachment 248463 [details]
v2

Hello,

I reviewed the patch and made the following changes:

- Add a dependency to qt6-svg. The buttons wont be displayed properly without it.
- Specify the correct path for the musicpd binary in qm_mpdcom.cpp

This PR is approved.

Thanks!
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2024-02-19 07:14:40 UTC
^Triage: deassign to non-committer.  maintainer-feedback+ is sufficient here.