Bug 279175
| Summary: | editors/neovim: Upgrade to 0.10.0 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Laurent Chardon <laurent.chardon> | ||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | markj, pi | ||||||||
| Priority: | --- | Flags: | pi:
maintainer-feedback+
|
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 250825 [details]
Improved patch: builds in poudriere
pkg-plist issues sorted
Build in poudriere
testbuils@work (In reply to Kurt Jaeger from comment #2) testbuilds done on 150 141 140 15i 133 132 (all amd64 except 15i) run-test: ld-elf.so.1: Cannot open "/usr/local/lib/lua/5.1/lpeg.so" (In reply to Kurt Jaeger from comment #4) I assume that the errors occurred with the obsolete patch. The improved patch works for me. I'll clean it up and submit a new version for commit. When I checked to see why lua > 5.1 didn't work, I found documentation at https://neovim.io/doc/user/faq.html#faq section "WHY LUA 5.1 INSTEAD OF LUA 5.3+" that neovim froze the version of lua to 5.1. So specifying USES=lua:51 is correct. Created attachment 250828 [details]
Patch ready for commit
Ready for commit
Passes poudriere 150 140 133 132 124 amd64
(In reply to Kurt Jaeger from comment #4) THe BUILD_DEPENDS for lua-lpeg is also a run-depend ? (In reply to Kurt Jaeger from comment #7) If no lua51-lpeg is installed, installing neovim should also install lua51-lpeg and lua51-bitop, but doesn't. Test by adding approriate RUN_DEPENDS seems to work. Committed (minor changes because of portclippy), thanks for the patch! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=61971843fd48f9b59b3e7169643064453607c586 commit 61971843fd48f9b59b3e7169643064453607c586 Author: Laurant Chardon <laurent.chardon@gmail.com> AuthorDate: 2024-05-20 14:51:01 +0000 Commit: Kurt Jaeger <pi@FreeBSD.org> CommitDate: 2024-05-20 14:51:01 +0000 editors/neovim: update 0.9.5 -> 0.10.0 Author: Laurant Chardon <laurent.chardon@gmail.com> Changes: https://gpanders.com/blog/whats-new-in-neovim-0.10/ https://neovim.io/doc/user/news-0.10.html Approved: adamw (implicit) PR: 279175 editors/neovim/Makefile | 32 +++++++++--------------- editors/neovim/distinfo | 10 ++++---- editors/neovim/files/patch-CMakeLists.txt (gone) | 14 ----------- 3 files changed, 17 insertions(+), 39 deletions(-) After this update, I get errors when opening lua code in my editor. See PR 279359. |
Created attachment 250823 [details] 0001-editors-neovim-Upgrade-to-0.10.0.patch First stab, in response to request on mailing list. This is not ready for commit. WIP TODO: - Fix plist - %%DATADIR%% entries - %%NLS%% missing - man page missing - Add test target - Check that not too much was removed (e.g. man page) - Check why lua > 51 broken, fix if possible - Review Makefile - Poudriere tests