Bug 279175 - editors/neovim: Upgrade to 0.10.0
Summary: editors/neovim: Upgrade to 0.10.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-20 03:16 UTC by Laurent Chardon
Modified: 2024-05-28 02:16 UTC (History)
2 users (show)

See Also:
pi: maintainer-feedback+

Attachments
0001-editors-neovim-Upgrade-to-0.10.0.patch (81.31 KB, patch)
2024-05-20 03:16 UTC, Laurent Chardon 		no flags Details | Diff
Improved patch: builds in poudriere (4.71 KB, patch)
2024-05-20 04:36 UTC, Laurent Chardon 		no flags Details | Diff
Patch ready for commit (4.68 KB, patch)
2024-05-20 13:37 UTC, Laurent Chardon 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Chardon 2024-05-20 03:16:34 UTC 
Created attachment 250823 [details]
0001-editors-neovim-Upgrade-to-0.10.0.patch

First stab, in response to request on mailing list.

This is not ready for commit.

WIP

TODO:
- Fix plist
  - %%DATADIR%% entries
  - %%NLS%% missing
  - man page missing
- Add test target
  - Check that not too much was removed (e.g. man page)
- Check why lua > 51 broken, fix if possible
- Review Makefile
- Poudriere tests
Comment 1 Laurent Chardon 2024-05-20 04:36:25 UTC 
Created attachment 250825 [details]
Improved patch: builds in poudriere

pkg-plist issues sorted
Build in poudriere
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2024-05-20 07:31:11 UTC 
testbuils@work
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2024-05-20 08:30:07 UTC 
(In reply to Kurt Jaeger from comment #2)
testbuilds done on 150 141 140 15i 133 132 (all amd64 except 15i)
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2024-05-20 08:31:46 UTC 
run-test:

ld-elf.so.1: Cannot open "/usr/local/lib/lua/5.1/lpeg.so"
Comment 5 Laurent Chardon 2024-05-20 13:36:15 UTC 
(In reply to Kurt Jaeger from comment #4)

I assume that the errors occurred with the obsolete patch. The improved patch works for me. I'll clean it up and submit a new version for commit.

When I checked to see why lua > 5.1 didn't work, I found documentation at https://neovim.io/doc/user/faq.html#faq section "WHY LUA 5.1 INSTEAD OF LUA 5.3+" that neovim froze the version of lua to 5.1. So specifying USES=lua:51 is correct.
Comment 6 Laurent Chardon 2024-05-20 13:37:34 UTC 
Created attachment 250828 [details]
Patch ready for commit

Ready for commit

Passes poudriere 150 140 133 132 124 amd64
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2024-05-20 14:28:07 UTC 
(In reply to Kurt Jaeger from comment #4)

THe BUILD_DEPENDS for lua-lpeg is also a run-depend ?
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2024-05-20 14:43:17 UTC 
(In reply to Kurt Jaeger from comment #7)
If no lua51-lpeg is installed, installing neovim should also install
lua51-lpeg and lua51-bitop, but doesn't. Test by adding approriate RUN_DEPENDS
seems to work.
Comment 9 Kurt Jaeger freebsd_committer freebsd_triage 2024-05-20 14:55:21 UTC 
Committed (minor changes because of portclippy), thanks for the patch!
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-05-20 14:55:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=61971843fd48f9b59b3e7169643064453607c586

commit 61971843fd48f9b59b3e7169643064453607c586
Author:     Laurant Chardon <laurent.chardon@gmail.com>
AuthorDate: 2024-05-20 14:51:01 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2024-05-20 14:51:01 +0000

    editors/neovim: update 0.9.5 -> 0.10.0

    Author:         Laurant Chardon <laurent.chardon@gmail.com>
    Changes:        https://gpanders.com/blog/whats-new-in-neovim-0.10/
                    https://neovim.io/doc/user/news-0.10.html
    Approved:       adamw (implicit)
    PR:             279175

 editors/neovim/Makefile                          | 32 +++++++++---------------
 editors/neovim/distinfo                          | 10 ++++----
 editors/neovim/files/patch-CMakeLists.txt (gone) | 14 -----------
 3 files changed, 17 insertions(+), 39 deletions(-)
Comment 11 Mark Johnston freebsd_committer freebsd_triage 2024-05-28 02:16:21 UTC 
After this update, I get errors when opening lua code in my editor.  See PR 279359.