Summary: | devd_enable="NO" do not set hw.bus.devctl_queue to 0 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Dmitry Lukhtionov <dmitryluhtionov> | ||||||||
Component: | conf | Assignee: | Eugene Grosbein <eugen> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Some People | CC: | eugen | ||||||||
Priority: | --- | Flags: | eugen:
mfc-stable14+
eugen: mfc-stable13+ |
||||||||
Version: | 14.0-STABLE | ||||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
Attachments: |
|
Description
Dmitry Lukhtionov
2024-05-21 10:39:42 UTC
Created attachment 250852 [details]
proposed fix
Please apply proposed patch to /etc/rc.d/devd and report back.
Created attachment 250856 [details]
proposed fix
Better fix. Changes both /etc/rc.subr and /etc/rc.d/devd. Apply to /etc directory.
Created attachment 250858 [details]
proposed fix
Fix devd part.
Working with path ``` mitya@vpn:/etc/rc.d# service devd start hw.bus.devctl_queue: 1000 -> 0 Cannot 'start' devd. Set devd_enable to YES in /etc/rc.conf or use 'onestart' instead of 'start'. ``` A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=32a579e4fc69a65e8901111ad5f65ec56a97dfab commit 32a579e4fc69a65e8901111ad5f65ec56a97dfab Author: Eugene Grosbein <eugen@FreeBSD.org> AuthorDate: 2024-06-02 19:13:42 +0000 Commit: Eugene Grosbein <eugen@FreeBSD.org> CommitDate: 2024-06-02 19:29:22 +0000 rc.subr(8): introduce ${name}_offcmd New variable ${name}_offcmd may be used to supply commands executed if named service is not enabled. Previously start_precmd could be used for such a task but now rc.subr(8) does not call it if a service is not enabled. Fix devd startup script to use it instead of start_precmd. PR: 279198 MFC after: 2 weeks Reported by: Dmitry S. Lukhtionov Tested by: Dmitry S. Lukhtionov libexec/rc/rc.d/devd | 7 +++---- libexec/rc/rc.subr | 25 +++++++++++++++++++++---- share/man/man8/rc.subr.8 | 4 +++- 3 files changed, 27 insertions(+), 9 deletions(-) ^Triage: set flags for possible MFCs. A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=efb1717d21c2cc488955914cb4fe9f3683b9cbe5 commit efb1717d21c2cc488955914cb4fe9f3683b9cbe5 Author: Eugene Grosbein <eugen@FreeBSD.org> AuthorDate: 2024-06-02 19:13:42 +0000 Commit: Eugene Grosbein <eugen@FreeBSD.org> CommitDate: 2024-06-17 04:57:53 +0000 rc.subr(8): MFC: introduce ${name}_offcmd New variable ${name}_offcmd may be used to supply commands executed if named service is not enabled. Previously start_precmd could be used for such a task but now rc.subr(8) does not call it if a service is not enabled. Fix devd startup script to use it instead of start_precmd. PR: 279198 Reported by: Dmitry S. Lukhtionov Tested by: Dmitry S. Lukhtionov (cherry picked from commit 32a579e4fc69a65e8901111ad5f65ec56a97dfab) (cherry picked from commit c2db3a0c7d31116028b38b426a9b139d26cbc7e5) libexec/rc/rc.d/devd | 7 +++---- libexec/rc/rc.subr | 25 +++++++++++++++++++++---- share/man/man8/rc.subr.8 | 4 +++- 3 files changed, 27 insertions(+), 9 deletions(-) A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=61d43332e6882c6c3c3be1473d38db3a9803b32d commit 61d43332e6882c6c3c3be1473d38db3a9803b32d Author: Eugene Grosbein <eugen@FreeBSD.org> AuthorDate: 2024-06-02 19:13:42 +0000 Commit: Eugene Grosbein <eugen@FreeBSD.org> CommitDate: 2024-06-17 05:06:59 +0000 rc.subr(8): MFC: introduce ${name}_offcmd New variable ${name}_offcmd may be used to supply commands executed if named service is not enabled. Previously start_precmd could be used for such a task but now rc.subr(8) does not call it if a service is not enabled. Fix devd startup script to use it instead of start_precmd. PR: 279198 Reported by: Dmitry S. Lukhtionov Tested by: Dmitry S. Lukhtionov (cherry picked from commit 32a579e4fc69a65e8901111ad5f65ec56a97dfab) (cherry picked from commit c2db3a0c7d31116028b38b426a9b139d26cbc7e5) libexec/rc/rc.d/devd | 7 +++---- libexec/rc/rc.subr | 25 +++++++++++++++++++++---- share/man/man8/rc.subr.8 | 4 +++- 3 files changed, 27 insertions(+), 9 deletions(-) Fix committed and merged. |