Bug 279198 - devd_enable="NO" do not set hw.bus.devctl_queue to 0
Summary: devd_enable="NO" do not set hw.bus.devctl_queue to 0
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: 14.0-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: Eugene Grosbein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-21 10:39 UTC by Dmitry Lukhtionov
Modified: 2024-06-17 05:10 UTC (History)
1 user (show)

See Also:
eugen: mfc-stable14+
eugen: mfc-stable13+


Attachments
proposed fix (367 bytes, patch)
2024-05-21 11:41 UTC, Eugene Grosbein
no flags Details | Diff
proposed fix (1.77 KB, patch)
2024-05-21 12:51 UTC, Eugene Grosbein
no flags Details | Diff
proposed fix (1.92 KB, patch)
2024-05-21 14:15 UTC, Eugene Grosbein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Lukhtionov 2024-05-21 10:39:42 UTC
devd_enable="NO" do not set hw.bus.devctl_queue to 0

FreeBSD vpn 14.0-STABLE FreeBSD 14.0-STABLE #0 stable/14-n267376-ca8e2e4c91cc: Thu Apr 18 05:55:35 UTC 2024     root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64
Comment 1 Eugene Grosbein freebsd_committer freebsd_triage 2024-05-21 11:41:14 UTC
Created attachment 250852 [details]
proposed fix

Please apply proposed patch to /etc/rc.d/devd and report back.
Comment 2 Eugene Grosbein freebsd_committer freebsd_triage 2024-05-21 12:51:32 UTC
Created attachment 250856 [details]
proposed fix

Better fix. Changes both /etc/rc.subr and /etc/rc.d/devd. Apply to /etc directory.
Comment 3 Eugene Grosbein freebsd_committer freebsd_triage 2024-05-21 14:15:54 UTC
Created attachment 250858 [details]
proposed fix

Fix devd part.
Comment 4 Dmitry Lukhtionov 2024-05-30 13:13:12 UTC
Working with path

```
mitya@vpn:/etc/rc.d# service devd start
hw.bus.devctl_queue: 1000 -> 0
Cannot 'start' devd. Set devd_enable to YES in /etc/rc.conf or use 'onestart' instead of 'start'.
```
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-06-02 19:29:59 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=32a579e4fc69a65e8901111ad5f65ec56a97dfab

commit 32a579e4fc69a65e8901111ad5f65ec56a97dfab
Author:     Eugene Grosbein <eugen@FreeBSD.org>
AuthorDate: 2024-06-02 19:13:42 +0000
Commit:     Eugene Grosbein <eugen@FreeBSD.org>
CommitDate: 2024-06-02 19:29:22 +0000

    rc.subr(8): introduce ${name}_offcmd

    New variable ${name}_offcmd may be used to supply commands
    executed if named service is not enabled. Previously start_precmd
    could be used for such a task but now rc.subr(8) does not call it
    if a service is not enabled.

    Fix devd startup script to use it instead of start_precmd.

    PR:             279198
    MFC after:      2 weeks
    Reported by:    Dmitry S. Lukhtionov
    Tested by:      Dmitry S. Lukhtionov

 libexec/rc/rc.d/devd     |  7 +++----
 libexec/rc/rc.subr       | 25 +++++++++++++++++++++----
 share/man/man8/rc.subr.8 |  4 +++-
 3 files changed, 27 insertions(+), 9 deletions(-)
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2024-06-14 03:45:37 UTC
^Triage: set flags for possible MFCs.
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-06-17 04:59:54 UTC
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=efb1717d21c2cc488955914cb4fe9f3683b9cbe5

commit efb1717d21c2cc488955914cb4fe9f3683b9cbe5
Author:     Eugene Grosbein <eugen@FreeBSD.org>
AuthorDate: 2024-06-02 19:13:42 +0000
Commit:     Eugene Grosbein <eugen@FreeBSD.org>
CommitDate: 2024-06-17 04:57:53 +0000

    rc.subr(8): MFC: introduce ${name}_offcmd

    New variable ${name}_offcmd may be used to supply commands
    executed if named service is not enabled. Previously start_precmd
    could be used for such a task but now rc.subr(8) does not call it
    if a service is not enabled.

    Fix devd startup script to use it instead of start_precmd.

    PR:             279198
    Reported by:    Dmitry S. Lukhtionov
    Tested by:      Dmitry S. Lukhtionov

    (cherry picked from commit 32a579e4fc69a65e8901111ad5f65ec56a97dfab)
    (cherry picked from commit c2db3a0c7d31116028b38b426a9b139d26cbc7e5)

 libexec/rc/rc.d/devd     |  7 +++----
 libexec/rc/rc.subr       | 25 +++++++++++++++++++++----
 share/man/man8/rc.subr.8 |  4 +++-
 3 files changed, 27 insertions(+), 9 deletions(-)
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-06-17 05:07:55 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=61d43332e6882c6c3c3be1473d38db3a9803b32d

commit 61d43332e6882c6c3c3be1473d38db3a9803b32d
Author:     Eugene Grosbein <eugen@FreeBSD.org>
AuthorDate: 2024-06-02 19:13:42 +0000
Commit:     Eugene Grosbein <eugen@FreeBSD.org>
CommitDate: 2024-06-17 05:06:59 +0000

    rc.subr(8): MFC: introduce ${name}_offcmd

    New variable ${name}_offcmd may be used to supply commands
    executed if named service is not enabled. Previously start_precmd
    could be used for such a task but now rc.subr(8) does not call it
    if a service is not enabled.

    Fix devd startup script to use it instead of start_precmd.

    PR:             279198
    Reported by:    Dmitry S. Lukhtionov
    Tested by:      Dmitry S. Lukhtionov

    (cherry picked from commit 32a579e4fc69a65e8901111ad5f65ec56a97dfab)
    (cherry picked from commit c2db3a0c7d31116028b38b426a9b139d26cbc7e5)

 libexec/rc/rc.d/devd     |  7 +++----
 libexec/rc/rc.subr       | 25 +++++++++++++++++++++----
 share/man/man8/rc.subr.8 |  4 +++-
 3 files changed, 27 insertions(+), 9 deletions(-)
Comment 9 Eugene Grosbein freebsd_committer freebsd_triage 2024-06-17 05:10:37 UTC
Fix committed and merged.