Summary: | games/minetest: Fix rc(8) script when using minetest_flags | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jesús Daniel Colmenares Oviedo <DtxdF> | ||||
Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | DtxdF | ||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(amdmi3) |
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Jesús Daniel Colmenares Oviedo
2024-05-23 13:34:22 UTC
Also, I see that `minetest_conffile` is not actually used but `minetest_config` is, so I made the changes accordingly. What do you think of instead: - Introducing `minetest_gameid` variable set to `minetest_game` by default, to make it work sort of out of box without rc.conf tuning, and more easily configurable if one only needs to change gameid. - Moving all arguments (`--config`, `--logfile`, `--world`, `--gameid`) to `command_args`, making them unconditionally specified. This leaves `minetest_args` empty by default and simplifies adding extra args if needed, without need to duplicate bits from default args. It's still also possible to override any of default args through `minetest_args`. See my patch: https://github.com/AMDmi3/freebsd-ports/compare/master...minetest This also fixes minetest_game when minetest is built without client. LGTM Just a small change: ``` # minetest_args (str): Additional argiments to minetestserver # (default: "") ``` `argiments` should be `arguments`. Thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f5c99763242c21f3ce4072ba5518d66b5174e84a commit f5c99763242c21f3ce4072ba5518d66b5174e84a Author: Dmitry Marakasov <amdmi3@FreeBSD.org> AuthorDate: 2024-05-24 20:42:37 +0000 Commit: Dmitry Marakasov <amdmi3@FreeBSD.org> CommitDate: 2024-05-27 16:25:24 +0000 games/minetest: fix rc.d script - Introduce `minetest_gameid` rc.d variable (set to minetest_game by default), which passes required --gameid to minetestserver. - Rework minetestserver arguments handling, simplify specifying extra arguments with `minetest_args`. - Add check for empty list of games, suggesting to install minetest_game port or other mods. - Fix `minetest_config` variable spelling PR: 279251 Submitted by: DtxdF@disroot.org games/minetest/Makefile | 1 + games/minetest/files/minetest.in | 28 ++++++++++++---------------- 2 files changed, 13 insertions(+), 16 deletions(-) |