Created attachment 250900 [details]
minetest.in.patch

Description:

After installing `games/minetest_game` and enabling the `rc(8)` script, it fails because I need to set the `--gameid` parameter. I set `minetest_flags`, which is theoretically the parameter that fixes the problem, but of course since `command` is set to `/usr/sbin/daemon`, those arguments are passed to `daemon(8)` instead of `minetest(6)`.

To fix this problem we need to change minetest_flags to minetest_cli_args after applying this patch.

Steps to reproduce this issue:

```
# service minetest oneenable
minetest enabled in /etc/rc.conf
# service minetest start
Starting minetest.
# service minetest status
minetest is not running.
# tail /var/log/minetest/debug.log
  
  
-------------
  Separator
-------------

2024-05-23 09:20:05: ERROR[Main]: To run a Minetest server, you need to select a game using the '--gameid' argument.
2024-05-23 09:20:05: ERROR[Main]: Check out https://content.minetest.net for a selection of games to pick from and download.
2024-05-23 09:20:05: ERROR[Main]: ServerError: Supplied invalid gamespec
# sysrc minetest_flags="--gameid minetest_game"
minetest_flags:  -> --gameid minetest_game
# service minetest start
Starting minetest.
daemon: unrecognized option `--gameid'
usage: daemon [-cfHrS] [-p child_pidfile] [-P supervisor_pidfile]
              [-u user] [-o output_file] [-t title]
              [-l syslog_facility] [-s syslog_priority]
              [-T syslog_tag] [-m output_mask] [-R restart_delay_secs]
command arguments ...
  --change-dir         -c         Change the current working directory to root
  --close-fds          -f         Set stdin, stdout, stderr to /dev/null
  --sighup             -H         Close and re-open output file on SIGHUP
  --syslog             -S         Send output to syslog
  --output-file        -o <file>  Append output of the child process to file
  --output-mask        -m <mask>  What to send to syslog/file
                                  1=stdout, 2=stderr, 3=both
  --child-pidfile      -p <file>  Write PID of the child process to file
  --supervisor-pidfile -P <file>  Write PID of the supervisor process to file
  --restart            -r         Restart child if it terminates (1 sec delay)
  --restart-delay      -R <N>     Restart child if it terminates after N sec
  --title              -t <title> Set the title of the supervisor process
  --user               -u <user>  Drop privileges, run as given user
  --syslog-priority    -s <prio>  Set syslog priority
  --syslog-facility    -l <flty>  Set syslog facility
  --syslog-tag         -T <tag>   Set syslog tag
  --help               -h         Show this help
/usr/local/etc/rc.d/minetest: WARNING: failed to start minetest
```

After applying this patch:

```
# service minetest oneenable
minetest enabled in /etc/rc.conf
# sysrc minetest_cli_args="--gameid minetest_game"
minetest_cli_args:  -> --gameid minetest_game
# service minetest start
Starting minetest.
# service minetest status
minetest is running as pid 57541.
# tail /var/log/minetest/debug.log 


-------------
  Separator
-------------

2024-05-23 09:31:43: [Main]: Using game specified by --gameid on the command line
2024-05-23 09:31:43: ACTION[Main]: World at [/var/db/minetest/world]
2024-05-23 09:31:43: ACTION[Main]: Server for gameid="minetest_game" listening on 0.0.0.0:30000.
```